fix(review-pr): 固定 Codex action v1.11 - #290
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
已核对 diff:.github/workflows/review-pr.yml 将 openai/codex-action@v1 固定到 v1.11 提交(52fe01ec70a42f454c9d2ebd47598f9fd6893d56),保留 20 分钟超时,并移除临时诊断日志步骤(Log AI review inputs、Log AI review result)、codex-final-message.txt 输出及对应的提示语。两个测试文件同步更新,仓库内已无 ai_review_start、codex-final-message 的遗留引用,test_codex_model_provider_config.py 与 test_review_workflow_dispatch.py 的断言与工作流现状一致,未发现阻塞性问题。
非阻塞观察(不在本次 diff 的改动范围):其余 10 个 Codex 工作流仍使用浮动的 openai/codex-action@v1(会解析到 v1.12)。按 PR 描述,v1.12 在 Linux 上等待 stdout/stderr 管道关闭导致的 hang 属于 action 级别问题,这些工作流下一次运行时有同等风险;如认同可在后续 PR 一并固定到同一提交,本次不阻塞合并。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
摘要
openai/codex-action@v1固定到已验证的 v1.11 commit,规避 v1.12 在 Linux 上等待 stdout/stderr 管道关闭导致的 action hang。验证
PYTHONDONTWRITEBYTECODE=1 .venv/bin/python -m unittest discover -s .github/aicodingflow-tests -p 'test_review_workflow_dispatch.py'git diff --checkRefs #288