Skip to content

fix(review-pr): 固定 Codex action v1.11 - #290

Merged
Terry-Mao merged 4 commits into
mainfrom
fix/pin-codex-action-288
Oct 3, 2026
Merged

Terry-Mao merged 4 commits into
mainfrom
fix/pin-codex-action-288

Conversation

@Terry-Mao

Copy link
Copy Markdown
Owner

摘要

  • 将 AI PR Review 使用的 openai/codex-action@v1 固定到已验证的 v1.11 commit,规避 v1.12 在 Linux 上等待 stdout/stderr 管道关闭导致的 action hang。
  • 保留现有 20 分钟超时作为兜底,移除已不再需要的临时诊断日志。

验证

  • PYTHONDONTWRITEBYTECODE=1 .venv/bin/python -m unittest discover -s .github/aicodingflow-tests -p 'test_review_workflow_dispatch.py'
  • git diff --check

Refs #288

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已核对 diff:.github/workflows/review-pr.yml 将 openai/codex-action@v1 固定到 v1.11 提交(52fe01ec70a42f454c9d2ebd47598f9fd6893d56),保留 20 分钟超时,并移除临时诊断日志步骤(Log AI review inputs、Log AI review result)、codex-final-message.txt 输出及对应的提示语。两个测试文件同步更新,仓库内已无 ai_review_start、codex-final-message 的遗留引用,test_codex_model_provider_config.py 与 test_review_workflow_dispatch.py 的断言与工作流现状一致,未发现阻塞性问题。

非阻塞观察(不在本次 diff 的改动范围):其余 10 个 Codex 工作流仍使用浮动的 openai/codex-action@v1(会解析到 v1.12)。按 PR 描述,v1.12 在 Linux 上等待 stdout/stderr 管道关闭导致的 hang 属于 action 级别问题,这些工作流下一次运行时有同等风险;如认同可在后续 PR 一并固定到同一提交,本次不阻塞合并。

@Terry-Mao
Terry-Mao merged commit c178033 into main Oct 3, 2026
3 checks passed
@Terry-Mao
Terry-Mao deleted the fix/pin-codex-action-288 branch October 3, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant