fix(review-pr): 增加 AI review 超时与诊断日志 - #289
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
本 PR 为 AI PR Review 的 Codex 执行步骤新增 20 分钟超时,并补充输入/结果诊断日志、最终消息 artifact 与相应测试。改动聚焦、与 PR 描述一致,未发现阻塞性问题。
补充说明(无精确改动行或影响较低,故不逐条内联):
- 新增的测试只断言了
AI_REVIEW_OUTCOME,未覆盖STARTED_AT输出;建议后续补一条断言,避免该诊断字段被意外移除。 - 新增日志只记录输入文件字节数、结果状态与输出文件大小,未打印快照内容或任何密钥,未发现安全问题。
- 除下述
duration_seconds的边界情况外,超时与诊断步骤顺序、id/输出引用(ai_review_start、ai_review)均正确。
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
本次改动仅涉及 AI PR Review 的 workflow 与对应单元测试:为 Codex 执行步骤补充 id: ai_review、timeout-minutes: 20(第 212、214 行)与 output-file: pr-worktree/codex-final-message.txt(第 220 行),新增 Log AI review inputs/Log AI review result 诊断步骤记录输入、耗时结果与输出文件大小,并把 Codex 最终消息纳入 artifact(第 289 行)。已核对 pr_diff.txt 中各行号与 workflow 配置一致,新增测试断言覆盖到位,本地运行 .github/aicodingflow-tests/test_review_workflow_dispatch.py 全部通过。未发现阻塞级正确性、安全性、测试或契约问题。review_discussion_context.json 中已解决且过期的 STARTED_AT 兜底评论,在当前 diff 第 252 行已通过 started_at="${STARTED_AT:-$finished_at}" 修复,故不再重复提出。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
摘要
验证
PYTHONDONTWRITEBYTECODE=1 .venv/bin/python -m unittest discover -s .github/aicodingflow-tests -p 'test_review_workflow_dispatch.py'git diff --checkCloses #288