feat(aws): storage.neptune — neptune-alpha port [stacked on #151] - #152
Open
so0k wants to merge 1 commit into
Open
feat(aws): storage.neptune — neptune-alpha port [stacked on #151]#152so0k wants to merge 1 commit into
so0k wants to merge 1 commit into
Conversation
…3.0-alpha.0 All 6 upstream files into storage.neptune, 83 tests. Neptune Serverless maps as a native typed serverless_v2_scaling_configuration block (docdb pattern — value known synchronously, no addOverride) with upstream's full validation set. kmsKey → kms_key_arn (the #151 id-vs-ARN lesson pre-applied). grant/grantConnect render neptune-db IAM statements against the clusterResourceIdentifier ARN with lazy iam-auth enablement. House patterns: grid-lowercased identifiers + derived-base instance naming (<clusterid>instanceN, regression-tested), skipFinalSnapshot/ finalSnapshotIdentifier + synth warning, Lambda-backed log retention TODO-omitted (native enable_cloudwatch_logs_exports wired). Build note: the conversion workflow died twice on API-connection failures and stalled; the 936-line cluster.test.ts port and gates were completed by hand (33 ported + 2 LogRetention comment-omitted + 2 repo additions). Live integ neptune.cluster: real Neptune Serverless 1-2.5 NCU + db.serverless instance, ServerlessV2ScalingConfiguration read back, grid-derived instance id asserted live, drift-clean, PASS 1684.18s.
Contributor
Author
Live apply/verify/destroy receipts —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storage slice PR 9 —
storage.neptune: the @aws-cdk/aws-neptune-alpha port (v2.263.0-alpha.0)Stacked on #151. All 6 upstream files into
storage.neptune, 83 tests. Second alpha port — same disciplines as #151: alpha-churn tracker on the barrel,aws-cdk-lib/interfacesmarkers stripped with TODO permalinks.Mapping notes
serverless_v2_scaling_configurationblock (known synchronously from props — the docdb pattern, no addOverride needed), with upstream's full validation set (min ≥ 1, max 2.5–128, min < max, db.serverless ⇢ config required).kmsKeymaps tokms_key_arn— the provider's own field naming enforces the ARN form here (the feat(aws): storage.elasticache — elasticache-alpha port [stacked on #150] #151 id-vs-ARN lesson arrives pre-applied), asserted in tests.grant/grantConnectrender theneptune-db:*IAM statements against theclusterResourceIdentifier-based ARN, flippingiam_database_authentication_enabledlazily exactly as upstream.<clusterid>instanceN, regression-tested), removalPolicy →skipFinalSnapshot/finalSnapshotIdentifier+ synth warning, Lambda-backedcloudwatchLogsRetentionTODO-omitted (nativeenable_cloudwatch_logs_exportswired),associatedRoles→iam_roles(ARNs).Vpc.fromLookuptest adapted to an imported security group (ContextProvider not ported — documented).Build-process note (honesty)
The conversion workflow for this module was killed twice by API-connection failures mid-run and finally stalled; the remaining ~40% (the 936-line
cluster.test.tsport and gates) was completed by hand and the whole surface re-verified against upstream during that port. Test counts: 35 upstream cluster tests → 33 ported + 2 LogRetention tests comment-omitted with permalinks + 2 repo-specific additions (grid naming, snapshot).Live integ (
make neptune.cluster) — receipts in threadReal Neptune Serverless cluster (1–2.5 NCU) +
db.serverlessinstance in an isolated VPC: engine/status/encryption read-backs,ServerlessV2ScalingConfigurationread back from AWS, the grid-derived instance identifier asserted live, drift oracle, clean destroy.