feat(aws): storage.rds FULL engine tables — 676+251 version constants [stacked on #144] - #146
Open
so0k wants to merge 1 commit into
Open
feat(aws): storage.rds FULL engine tables — 676+251 version constants [stacked on #144]#146so0k wants to merge 1 commit into
so0k wants to merge 1 commit into
Conversation
…luster-engine (251) at v2.263.0 RDS PR 2b: complete version tables, no subsetting (exact upstream counts enforced as workflow gates), zero omission TODOs, @deprecated markers kept. Deviations: lazy/memoized rotation-application getters (breaks the encryption<->storage/rds module cycle; regression-locked by tests) and iam.IRole in place of the ungenerated IRoleRef layer. semver added as a BUNDLED dep via .projenrc.ts (mirrors upstream aws-cdk-lib). Tightening: OptionGroupProps.engine restored to IInstanceEngine; test stand-ins replaced with real engines. rds.groups fixture now derives families from the real tables (postgres16 / aurora-postgresql16 / mariadb 10.6) — live PASS 154.55s, 13/13, drift oracle clean.
Contributor
Author
Live apply/verify/destroy receipts —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storage slice PR 3/N —
storage.rdsengine tables, IN FULL (v2.263.0)Stacked on #144. Lands
instance-engine.ts(5,197 lines) andcluster-engine.ts(2,372 lines) — the complete engine/version tables, no subsetting:public static readonlymembers ininstance-engine.tsand 251 incluster-engine.ts— exact upstream counts, enforced as hard CI-style gates in the conversion workflow and re-verified by an adversarial pass that spot-checked first/last plus random constants per engine family (names, version strings,@deprecatedmarkers).TODO: omittedmarkers — nothing was dropped from either file.@deprecatedversion markers kept intact.Deviations (8 comments, 2 root causes)
singleUserRotationApplication/multiUserRotationApplicationare resolved via memoized getters instead of upstream's eager readonly fields —../../encryption(SecretRotationApplication) transitively imports back into thestorage/rdsbarrel, and eager resolution during module-graph loading throws. Callers can't tell the difference; regression-locked by new tests (resolved app IDs per engine family + identity/memoization assertions, load-order verified).s3ImportRole/s3ExportRoletypediam.IRole(upstream uses the generatedIRoleReflayer TerraConstructs doesn't have).Tightening (closes PR 2's temporary widenings)
OptionGroupProps.enginerestored toIInstanceEngine(the jsii-breaking-if-released widening flagged in feat(aws): storage.rds foundations — engines, groups, DatabaseSecret, canned metrics [stacked on #142] #144 is resolved within the same stack).IEnginestand-in literals in tests replaced with realrds.DatabaseInstanceEngine.*/rds.DatabaseClusterEngine.*exactly as upstream tests use them.semver@^7.6.0added via.projenrc.tsas a bundled dep (jsii-correct; mirrors upstream aws-cdk-lib's own bundled semver) — used by cluster-engine's aurora version-family logic, same as upstream.Tests
248 rds suite tests green (ported upstream
instance-engine.test.ts+cluster-engine.test.tsincl. the parameterGroupFamily derivation matrices, + rotation-application regression tests). jsii compile clean.Live integ
The
rds.groupsfixture now constructs its engines from the real tables (DatabaseInstanceEngine.postgres(VER_16),DatabaseClusterEngine.auroraPostgres(VER_16_4),DatabaseInstanceEngine.mariaDb(VER_10_6)) instead of stand-in literals — the live run therefore proves theparameterGroupFamily/majorEngineVersionderivations against the real AWS APIs (postgres16,aurora-postgresql16,10.6). Receipts in thread.