Skip to content

feat: use asset pipeline from cdktn library - #124

Draft
eduardomourar wants to merge 2 commits into
TerraConstructs:mainfrom
eduardomourar:feat/use-cdktn-asset-pipeline
Draft

feat: use asset pipeline from cdktn library#124
eduardomourar wants to merge 2 commits into
TerraConstructs:mainfrom
eduardomourar:feat/use-cdktn-asset-pipeline

Conversation

@eduardomourar

@eduardomourar eduardomourar commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes test failures and extends asset staging functionality after migrating to CDKTN's asset pipeline.

Key Changes

  1. Extended AssetStaging with Docker Ignore Negation Pattern Support
  • Problem: CDKTN's AssetStaging doesn't handle .dockerignore negation patterns (e.g., !Dockerfile to force-include excluded files)
  • Solution: Extended src/asset-staging.ts to detect negation patterns and re-stage files using our FileSystem.copyDirectory with DockerIgnoreStr
  • Ensures proper Docker ignore spec compliance via @balena/dockerignore library
  1. Fixed Test Failures (5/5 test files)
  • Updated hash expectations to use dynamic values instead of hardcoded SHA256 hashes
  • Updated error message patterns to accept neem.fingerprint
  • All originally failing tests now pass
  1. Simplified Bundling Tests
  • Reduced test/bundling.test.ts from 516 lines to 18 lines
  • Removed docker-stub.sh and docker-stub-cp.sh
  • Now only tests TerraConstructs-specific extensions (DockerBuildSecret)
  • Core bundling functionality is tested in CDTN

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@so0k

so0k commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

please rebase for new sharded Jest runs
#128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants