ci: run the Rust jobs when proptest seeds change - #329
Merged
Merged
Conversation
The `rust` path filter listed only `.rs`, manifests and lint config, but proptest replays `proptest-regressions/**` before any new case, so the seeds are test input. #328 only moved such a file: `ci-success` passed with `test` and `portable` skipped. Add `**/proptest-regressions/**` to `rust`, and record in docs/CI.md that a skipped job is a green that tested nothing. Checked: picomatch (what paths-filter uses) matches the four seed files and not the docs; actionlint passes. Not covered: crates/app/icons/256x256.png is embedded with include_bytes! and is still outside the filter.
bastien-gallay
added a commit
that referenced
this pull request
Sep 25, 2026
* docs(roadmap): the scroll-drift property carries no known failure, #102 was test noise The builtin-terminal entry named the failing emitted_lines_never_drift sequence (#102) as the one contract bug left on the surface. It was f32 noise in the test's reference sum, fixed by b1d8045 the day after it was filed; #102 closed on 2026-09-24 and its seed replays since #328. The claim is retracted in place rather than deleted. * docs(agents): one still-open list for the mcp surface, not two contradicting copies 89e7d21 (#318) re-added a pre-#320 'Three features and two defects' paragraph, still listing #196 as open, beside the current 'Two features and two defects' one. Keep the current list, carry over its #316 sentence, note the hardening defects it leaves out (#284, #293), and keep the one fact the removed #196 paragraph held alone: the composed wait needed #236 first. * docs(agents): a moved proptest file leaves its seeds unread proptest derives the regressions path from file!(), so the drift test's move out of shell/terminal.rs (34d23a6) left its committed seeds unread until #328, with no signal. Promote it to the Quality bar: git mv the regressions file with its test, and treat it as CI test input (#329). * docs(wrap): markdownlint's summary counts files with findings, not files linted A clean run ends 'Summary: 0 issues in 0 files'; coverage is the 'Linting: N files' line. Cut off by a tail -1 in the #102 pass, it was misread as a vacuous pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #328 only moved a proptest regression file.
ci-successpassed, buttestand
portablewere skipped: therustpath filter lists.rsfiles,manifests and lint config, and not
proptest-regressions/**. proptest replaysthose seeds before generating any new case, so they are test input.
What
.github/workflows/ci.yml: add'**/proptest-regressions/**'to therustfilter.
docs/CI.md: add that a skipped job is a green that tested nothing, andthat a test reading a new kind of non-
.rsfile needs its path inrust.Evidence
dorny/paths-filteruses, matches all four seed files(
crates/{app,core,pty}/proptest-regressions/…) and notdocs/CI.md.actionlintpasses. markdownlint passes ondocs/CI.md, and a line injectedon purpose was flagged, so the linter did run.
rule. The next PR that does will.
Not covered
crates/app/icons/256x256.pngis compiled in withinclude_bytes!and isstill outside the filter.