Fixing alert dashboard issue with grafana 5.x.x#579
Conversation
|
@shtripat @cloudbehl @nthomas-redhat @anmolsachan, please review I saw exiting logic also causing some issue with the alert dashboard, especially with a host alert dashboard. I did a very small change for that. The main dashboard does not have any problem. |
|
Verified |
|
|
||
| if 'dashboard' in dashboard_json: | ||
| dashboard_id = dashboard_json.get('dashboard').get('id') | ||
| response = dashboard_utils.set_home_dashboard(dashboard_id) |
There was a problem hiding this comment.
This line is redundant, So i removed it
There was a problem hiding this comment.
redundant line
|
After fixing:
|
|
We don't need to take this issue for now, we are still not moved to grafana 5.x.x |
I did small change to work existing alerting logic to work with latest grafana. tendrl-bug-id: Tendrl#372 Signed-off-by: GowthamShanmugasundaram <gshanmug@redhat.com>
GowthamShanmugam
force-pushed
the
grafana-5.x.x
branch
from
4e1f029 to
0ece42f
Compare
Codecov Report
@@ Coverage Diff @@
## master #579 +/- ##
=========================================
Coverage ? 44.15%
=========================================
Files ? 41
Lines ? 2351
Branches ? 352
=========================================
Hits ? 1038
Misses ? 1260
Partials ? 53
Continue to review full report at Codecov.
|
shtripat
left a comment
shtripat
left a comment
There was a problem hiding this comment.
Looks fine. Make sure it tested extensively.
2 participants
I did small change to work existing alerting logic to work with
latest grafana.
tendrl-bug-id: #372
Signed-off-by: GowthamShanmugasundaram gshanmug@redhat.com