Skip to content

Add reviewed visual baselines for home, docs, catalog and playground - #9

Merged
wilkinsantana merged 3 commits into
mainfrom
test/visual-baselines
Nov 8, 2026
Merged

wilkinsantana merged 3 commits into
mainfrom
test/visual-baselines

Conversation

@wilkinsantana

@wilkinsantana wilkinsantana commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Adds 16 approved baseline images and a separate Chromium screenshot suite covering home, docs, catalog and playground at desktop/mobile widths in light/dark themes. CI compares each view twice, retains bounded difference evidence and uses a negative control to prove a missing heading is detected. Existing Chromium/WebKit behavior coverage stays intact. No production page, CSS or navigation changes.

Closes #3.

Capture provenance: initial 14 images from run 42528307842 at 36a3e99 (artifact 13635848206); mobile Docs images from run 42528912121 at f61b4f0 (artifact 13636344037). Codex visually inspected all 16 for readable text, wrapping, intact header/controls and clipping. The maintainer approved all 16 images and authorized DCO sign-off.

Validation at 3b8e626: website native verification 42529261852 passed; browser run 42529261804 passed existing behavior checks and 34 visual checks (16 baseline views repeated twice, two successful deliberate-regression controls; two redundant mobile negative controls intentionally skipped). No flaky or unexpected results. Final visual artifact 13637055580. JavaScript syntax and diff checks passed. Normal CI cannot silently update baselines; review/update instructions are in tests/browser/VISUAL.md.

AI assistance: implementation, documentation and preliminary image review by Codex. Human review, baseline approval and DCO authorization are complete. Signed head fd175c2 preserves the tested file tree; All required CI passed on the signed head: native verification 42532326184, browser/visual verification 42532326181 and DCO 42532326211.

Copy link
Copy Markdown
Contributor Author

Initial capture provenance: run 42528307842, source 36a3e99, visual artifact 13635848206. Codex inspected 14 screenshots (all desktop states plus mobile home/catalog/playground in both themes): intact header and controls, readable wrapping, no horizontal clipping. These are proposed baseline images pending human approval. Mobile Docs timed out while the harness waited for a hidden image; the wait now covers only viewport-visible images. The next run will produce those two missing candidates and compare the other 14.

Added a negative control that hides the home heading and requires a pixel-difference failure, proving the matcher detects an actual regression. No shipped page, CSS, dependency or menu label changed.

@wilkinsantana wilkinsantana changed the title Establish reviewed visual baselines for the website Add reviewed visual baselines for home, docs, catalog and playground Nov 8, 2026
Signed-off-by: Wilkin Santana <28665914+wilkinsantana@users.noreply.github.com>
Signed-off-by: Wilkin Santana <28665914+wilkinsantana@users.noreply.github.com>
Signed-off-by: Wilkin Santana <28665914+wilkinsantana@users.noreply.github.com>

Copy link
Copy Markdown
Contributor Author

The maintainer explicitly approved all screenshot baselines and authorized their DCO sign-off in the working session. All three PR commits now carry author-matching sign-offs; local DCO verification passes. Head fd175c2 has exactly the same file tree as the previously tested 3b8e626. Required CI is rerunning on the signed commit IDs. Maintainer-authorized delivery will use the documented administrator PR-only review exception if needed, while waiting for required automated checks.

@wilkinsantana
wilkinsantana marked this pull request as ready for review November 8, 2026 22:52
@wilkinsantana
wilkinsantana merged commit f1fc5ba into main Nov 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Establish reviewed visual regression baselines for the public site

1 participant