Skip to content

fix: resolve #1074 — Gradle 5.1.1依赖传递丢失tinker-android-loader#1799

Open
Nam0101 wants to merge 1 commit into
Tencent:devfrom
Nam0101:contribai/improve/quality/ensure-tinker-android-loader-is-declared
Open

fix: resolve #1074 — Gradle 5.1.1依赖传递丢失tinker-android-loader#1799
Nam0101 wants to merge 1 commit into
Tencent:devfrom
Nam0101:contribai/improve/quality/ensure-tinker-android-loader-is-declared

Conversation

@Nam0101
Copy link
Copy Markdown

@Nam0101 Nam0101 commented May 16, 2026

Summary

fix: resolve #1074 — Gradle 5.1.1依赖传递丢失tinker-android-loader

Problem

Severity: High | File: tinker-android/tinker-android-lib/build.gradle

The root cause is that tinker-android-loader is currently declared in tinker-android-lib/build.gradle using a configuration (likely provided or compileOnly) that gets serialized into the published POM with <scope>provided</scope>. Gradle 4.x leniently included provided dependencies as transitive in some resolution paths, but Gradle 5.x strictly excludes them, which is why users on AS 3.4 / Gradle 5.1.1 see the dependency vanish from the resolved graph. Meanwhile tinker-commons is declared as compile/api, so it still appears.

Solution

Changes

  • tinker-android/tinker-android-lib/build.gradle (modified)

Testing

  • Existing tests pass
  • Manual review completed
  • No new warnings/errors introduced

Note: this change was drafted with AI assistance and reviewed locally before submission.

Fixes Tencent#1074

Signed-off-by: Nguyen Van Nam <nam.nv205106@gmail.com>
@tencent-adm
Copy link
Copy Markdown
Member

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gradle 5.1.1依赖传递丢失tinker-android-loader

2 participants