Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow
contribute --namespace <ns>to choose an active learnings namespace when a directory reads several namespaces. Invalid targets are rejected before queue/index/worktree writes; omitting the option preserves the existing single-namespace/shared-root default.projects listnow shows the default destination and accepted namespaces. Update CLI help, its generated command reference, both usage guides and the affected design. AllSKILL.mdbodies remain unchanged.Type of Change
Test Plan
Local macOS, Node 26.7.0:
git diff --check, and the generated command-reference check passed.npm run test:e2eafter reverting skill changes: 545 passed, 50 skipped, 5 failed. The five failures are all instats-recall-dry-run.test.ts; a separate, unmodifieda8957a8checkout reproduces the same five failures. These existing failures are addressed by fix(dry-run): restore stats and recall previews with inferred credits #977, which is still open. Skips include unavailable Git hook capabilities and remote-provider credentials.Before the change, the built CLI on
a8957a8wrote contributions from a multi-namespace project to the shared root and rejected--namespace paymentsas an unknown option.After the change, a manual built-CLI run against a local bare Git remote verified: contribute to
learnings/payments/, verify the published bytes, recall from the contributor, then pull and recall the same content as a second isolated member. Dry-run left the complete fixture unchanged; an unavailable namespace exited 1 without publishing.Additional real-CLI checks passed for namespace names differing from project IDs, Unicode and spaces, two projects sharing one namespace, and an offline queued contribution retaining its original namespace after the active project changed. Additional remote-provider/agent coverage is deferred to CI.
Related Issues
Fixes #916
Notes for Reviewers
The selected namespace is stored in the existing queued relative path. Queue format, publication locks and retry behavior are unchanged. The whole branch diff and shared-state readers/writers were reviewed.