Repository navigation
Conversation
Signed-off-by: fuyuwei01 <fuyuwei01@qq.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2024 #1852 +/- ##
============================================
+ Coverage 55.86% 56.16% +0.29%
Complexity 152 152
============================================
Files 487 487
Lines 14458 14458
Branches 1827 1825 -2
============================================
+ Hits 8077 8120 +43
+ Misses 5716 5669 -47
- Partials 665 669 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Bugfix.
Describe what this PR does for and how you did.
TSF Swagger settings in local files or remote configuration could load after
TsfCoreEnvironmentPostProcessorhad already copied their startup values into contract properties. For example,tsf.swagger.group=my-apiwas visible in the environment while the generated API group still usedpolaris.Resolve the six legacy Swagger settings through placeholders in a low-priority
tsf-swagger-propertiessource:group,enabled,basePackage,excludePath,basePath, anddoc.auto-startup. Configuration loaded before Swagger initialization now reaches property binding and API generation. Explicitspring.cloud.polaris.contract.*settings take precedence, and existing TSF deployment bootstrap behavior is preserved.Validation:
git diff --checkpassed.Adding the issue link (#xxx) if possible.
N/A.
Note
These settings apply when Swagger initializes. Updating remote configuration changes the environment, but does not rebuild an existing
GroupedOpenApi; restart the application to apply group or scanning changes.The local Consul check covers configuration loading and document behavior. Cloud console publication and API metadata upload were not exercised. Full demo packaging encountered existing unrelated Checkstyle violations and used
-Ddisable.checks=true; the affected-module validation above passed with normal Checkstyle enabled.Checklist