feat(issue4): bitwise determinism diagnostic tool for NCCL collectives - #17
Open
xyaohubery wants to merge 1 commit into
Open
feat(issue4): bitwise determinism diagnostic tool for NCCL collectives#17xyaohubery wants to merge 1 commit into
xyaohubery wants to merge 1 commit into
Conversation
…tives Tool for detecting non-determinism in collective operations (AllReduce, Reduce-Scatter) via repeated runs with bitwise comparison. Includes: - bitwise_determinism_checker.py: Core engine with simulated Ring/Tree/ PAT/NVLS algorithms and bitwise comparison framework - nccl_config_injector.py: NCCL config sweep + topology pinning helper - Supports both simulation mode (numpy) and GPU mode (torch.distributed) - Algorithm sweep to identify which NCCL_ALGO configs cause divergence - Recommendations for deterministic collective configurations Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Diagnostic tool for detecting and localizing non-determinism in NCCL collective operations, addressing Issue #4.
Problem
Two identical training runs can diverge bitwise due to floating-point non-associativity in collective reductions (ring vs tree vs PAT algorithms, topology changes). This tool pinpoints the exact call and algorithm that introduces divergence.
What's Included
bitwise_determinism_checker.py: Core engine with simulated Ring/Tree/PAT/NVLS algorithms, bitwise comparison framework, algorithm sweep, and actionable recommendationsnccl_config_injector.py: NCCL config sweep, topology pinning, and torch.distributed integrationUsage
Key Findings
🤖 Generated with Claude Code