Skip to content

fix(evals): support cross-drive scaffold imports on Windows #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iuyo5678 merged 1 commit into from
Oct 20, 2026
Merged

fix(evals): support cross-drive scaffold imports on Windows #459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions evals/browser/lib/scaffold-case.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { mkdir, realpath, stat, writeFile } from "node:fs/promises";
import { join, relative, sep } from "node:path";
import { isAbsolute, join, relative, sep } from "node:path";
import { pathToFileURL } from "node:url";

import { casesDirectory, evalDirectory } from "./paths.mjs";

Expand All @@ -16,9 +17,10 @@ async function exists(path) {
}

async function moduleSpecifier(fromDirectory, target) {
const path = relative(await realpath(fromDirectory), await realpath(target))
.split(sep)
.join("/");
const targetPath = await realpath(target);
const relativePath = relative(await realpath(fromDirectory), targetPath);
if (isAbsolute(relativePath)) return pathToFileURL(targetPath).href;
const path = relativePath.split(sep).join("/");
return path.startsWith(".") ? path : `./${path}`;
}

Expand Down
Loading