Repository navigation
Conversation
|
@iuyo5678 Could you please review this PR and approve the hosted workflow when convenient? I have merged the latest The focused Rust checks pass on the merged head (44 CLI parsing tests, 172 protocol tests, and 9 session-registry tests). One new activity-renewal IPC test also passes locally; the two named-pipe lifecycle cases remain explicitly listed in the PR description for Hosted CI verification. I would especially appreciate review of the optional protocol fields, cooperation/idle interaction, and the 10-minute/1,024-entry process-local stop-reason bound. Thank you! |
Summary
Fixes #386.
Make session idle expiration observable without changing the default five-minute
timeout or daemon-global
--session-idleconfiguration.Changes
last_activity_at_ms,idle_timeout_ms, andidle_protectedfields to session-list entries.
bsk session listoutput, orpausedwhile active browser cooperationprotects the session from idle reaping.
session_idle_timeoutreason after the idle reapersuccessfully stops a session.
TTL, cleaning expired entries on reads and writes.
system.status.The cache stores only session IDs and monotonic timestamps. It is not persisted
and contains no URL, title, form, or page data.
Compatibility
--session-idleremains daemon-global.maincooperation lifecycle is preserved: active cooperationpauses idle reaping, and ending it starts a fresh idle interval.
responses and older clients can ignore the additional fields.
Validation
Passed locally on the merged head:
cargo fmt --checkcargo test -p bsk --test cli_parse --locked— 44 passedcargo test -p bsk-protocol --locked— 172 passedcargo test -p bsk daemon::sessions --locked— 9 passedbrowser_skill_tool_activity_renews_the_idle_deadline— passedgit diff --checkgit diff --cached --checkTwo focused
sessions_ipccases still cannot complete on this Windows hostbecause the test client cannot connect to the temporary named-pipe endpoint:
session_idle_timeout_stops_unregisters_and_explains_later_usesession_list_reports_non_sensitive_idle_lifecycle_metadataHosted CI must verify those cases.
pnpm lintis also not complete locallybecause this Windows checkout presents repository-wide CRLF formatting
differences, and
pnpm ext:teststops before executing tests because Vite/OXCcannot resolve the existing
apps/extension/tsconfig.json. No unrelated fileswere changed to mask either environment failure.