Skip to content

[WIP] Fix the multiple application sinks input. - #6

Merged
RiceaRaul merged 7 commits into
mainfrom
bug/multiple-sinks-audio
Jul 14, 2025
Merged

[WIP] Fix the multiple application sinks input.#6
RiceaRaul merged 7 commits into
mainfrom
bug/multiple-sinks-audio

Conversation

@RiceaRaul

Copy link
Copy Markdown
Contributor

[WIP] Bug #5

@RiceaRaul
RiceaRaul requested a review from Copilot July 13, 2025 21:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors how application audio streams are grouped by application name and adds support for fetching and displaying icon paths.

  • AudioService now returns streams grouped by application.
  • Frontend model and components updated to handle grouped streams and display icons.
  • Backend PipeWire manager extended to resolve icon files, encode them, and group streams via itertools.

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
PenguinWave/src/services/audioService.ts Changed getApplicationStreams return type to Record<string, ApplicationStream[]>
PenguinWave/src/models/audio.ts Added icon_path field to ApplicationStream
PenguinWave/src/components/PlaybackStreamsManager.tsx Updated state, grouping logic, and draggable components to work with grouped streams
PenguinWave/src-tauri/src/system/pipewire.rs Added icon_path field and icon resolution/encoding methods
PenguinWave/src-tauri/src/lib.rs Changed get_application_streams Tauri command to return grouped streams via into_group_map_by
PenguinWave/src-tauri/Cargo.toml Added itertools and base64 dependencies
Comments suppressed due to low confidence (1)

PenguinWave/src-tauri/src/lib.rs:137

  • The inline comment is outdated now that stream.name is the correct field; consider removing it to reduce confusion.
                .into_group_map_by(|stream| stream.name.clone()) // Replace 'name' with your actual field

Comment thread PenguinWave/src/models/audio.ts Outdated
Comment thread PenguinWave/src/components/PlaybackStreamsManager.tsx Outdated
Comment thread PenguinWave/src/components/PlaybackStreamsManager.tsx
Comment thread PenguinWave/src-tauri/src/system/pipewire.rs
RiceaRaul and others added 6 commits July 14, 2025 21:02
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@RiceaRaul
RiceaRaul requested a review from danut07 July 14, 2025 19:17
@RiceaRaul
RiceaRaul merged commit aaeef2c into main Jul 14, 2025
1 check passed
@RiceaRaul
RiceaRaul deleted the bug/multiple-sinks-audio branch June 23, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants