[WIP] Fix the multiple application sinks input. - #6
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors how application audio streams are grouped by application name and adds support for fetching and displaying icon paths.
- AudioService now returns streams grouped by application.
- Frontend model and components updated to handle grouped streams and display icons.
- Backend PipeWire manager extended to resolve icon files, encode them, and group streams via itertools.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| PenguinWave/src/services/audioService.ts | Changed getApplicationStreams return type to Record<string, ApplicationStream[]> |
| PenguinWave/src/models/audio.ts | Added icon_path field to ApplicationStream |
| PenguinWave/src/components/PlaybackStreamsManager.tsx | Updated state, grouping logic, and draggable components to work with grouped streams |
| PenguinWave/src-tauri/src/system/pipewire.rs | Added icon_path field and icon resolution/encoding methods |
| PenguinWave/src-tauri/src/lib.rs | Changed get_application_streams Tauri command to return grouped streams via into_group_map_by |
| PenguinWave/src-tauri/Cargo.toml | Added itertools and base64 dependencies |
Comments suppressed due to low confidence (1)
PenguinWave/src-tauri/src/lib.rs:137
- The inline comment is outdated now that
stream.nameis the correct field; consider removing it to reduce confusion.
.into_group_map_by(|stream| stream.name.clone()) // Replace 'name' with your actual field
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[WIP] Bug #5