revert: take scheduling back out of the core - #18
Merged
Merged
Conversation
Reverts 7e5e5c4, released as v0.10.0. Scheduling already has a home in the tasks plugin, which declares #[Task] with interval and cron scheduling both. A second #[Scheduled] in the core is a competing way to say the same thing, and would leave the plugin unable to be installed alongside the framework it extends. Nothing depends on the attribute a release later, so this is the cheapest moment to take it back out. What was worth having — each turn in a fiber, a skip when the previous turn is still running, containment that leaves a throwing task in the schedule — moves into the plugin with its tests.
|
🎉 This PR is included in version 0.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #16, released as
v0.10.0.I added
#[Scheduled]to the core without checking what was already planned. Tempcord/tasks already declares#[Task]with interval and cron scheduling, a console command and per-task statistics. A second attribute in the core is a competing way to say the same thing, and would leave the plugin unable to be installed alongside the framework it extends.Nothing depends on the attribute one release later, so this is the cheapest moment to take it back out.
What was worth having moves into the plugin along with its tests: each turn in a fiber so a task may
awaitthe REST API, a skip when the previous turn has not finished, and containment that logs a throwing task and leaves it in the schedule.🤖 Generated with Claude Code