fix(desk): filter check-in and room-move dropdowns by room type - #279
Merged
Conversation
role_permissions was unique on (role_id, permission_key) only. Once any property seeded a system role, later property bootstraps could skip grants for the same pair. Permission checks are property-scoped, so those tenants effectively had no grants. Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
Check-in and room-move dropdowns listed all vacant rooms regardless of reservation room type, causing API validation errors when a room of a different type was selected. Filter assignable rooms by reservation roomTypeId (matching walk-in behavior). Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
telivity-otaip
marked this pull request as ready for review
August 3, 2026 17:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Check-in and room-move dropdowns listed all vacant rooms regardless of reservation room type, causing API validation errors when a room of a different type was selected.
Changes
roomTypeIdinapps/dashboard/src/pages/FrontDesk.tsx(matching walk-in behavior).