fix(rbac): scope role_permissions unique index per property - #277
Merged
Conversation
Cloud tenant bootstrap was silently skipping permission grants once any property had seeded the same system roles, because the unique index was only (role_id, permission_key). New tenants then had zero grants and housekeeping.manage (Generate Stayovers) failed closed. Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
telivity-otaip
marked this pull request as ready for review
August 3, 2026 14:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
role_permissionsgrants were unique only on(role_id, permission_key). Once any property seeded a system role, later property bootstraps could skip grants for the same role/permission pair. Permissions checks are property-scoped, so those tenants effectively had no grants.Changes
0016_role_permissions_per_property.sql: unique index is(property_id, role_id, permission_key)push-schema.tsupdates