Move Google Analytics ID to config - #10
Merged
Merged
Conversation
3 tasks
Contributor
|
Thanks for the PR — this matches #1 well. One note for after merge: Telivity’s hosted deploy will need analyticsId set in the deployed web/config.js (empty/default = analytics off, which is what we want for self-hosters). Approving the first-time-contributor workflow now so Smoke can run; will merge once that’s green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves the Google Analytics Measurement ID out of
web/index.htmland into the configurableweb/config.jssetup.Fixes #1
Changes
analyticsIdfield toweb/config.example.jsCAREEROPS_CONFIG.analyticsIdis setweb/README.mdType
Checklist
web/config.jsnot committed)