Repository navigation
Conversation
Track in-flight error requests alongside event batches and bound flush to two seconds. Include pending errors in exit diagnostics, cover delayed delivery and timeouts, and document the caught-error job pattern. Bump core to 1.5.3 and node to 1.4.3 using existing workspace dependency handling. Refs #851
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base branch: develop
Summary
Refs #851 (TT-024). QA closes the issue after production verification.
trackError(error); await flush(); process.exit(1)previously exited before the handled error request completed. Core now tracks pending error promises in a Set, removes them on settlement, and waits for errors together with event batches for at most two seconds. Pending errors also count toward Node exit warnings. Fatal handler implementation and long-running batching are unchanged.Bumps core 1.5.2 → 1.5.3 and node 1.4.2 → 1.4.3. Node retains
workspace:*; the existing publisher rewrites it to the bumped core version. Updates the changelog, Node README, SDK guide and dashboard docs with the caught-error job example and timeout semantics.How to test
pnpm install --frozen-lockfile: passed.pnpm lint: passed.pnpm test: 1,794 passed, 179 skipped, 0 failed (including 17 publish-guard tests).pnpm build: passed, including API and dashboard production type checks.tsc --noEmit: passed.pnpm -r exec tsc --noEmit: failed with 112 errors in unchanged API test sources; production API build passes.git diff --check: passed.Handoff limitation
The task runner explicitly prohibits build output in FILES_TO_COMMIT.txt. Generated tracked SDK dist changes therefore remain in the worktree but are excluded from that list. This repository's CI checks committed SDK dist against the build; that gate will need the tracked dist updates before this PR can be merge-ready. Do not merge on this handoff alone.
Checklist
Security / privacy
No ingest payload, authentication or privacy changes. No production requests made. No merge, release, tag, npm publication or deployment performed. Sanja publishes; QA must then run the published-package production acceptance check twice.