feat(skin): support showBoxedBorder component property token - #1671
Open
AngeloOBonfante wants to merge 3 commits into
Open
feat(skin): support showBoxedBorder component property token#1671AngeloOBonfante wants to merge 3 commits into
AngeloOBonfante wants to merge 3 commits into
Conversation
brtbrt
requested changes
Jul 28, 2026
brtbrt
left a comment
brtbrt
left a comment
Contributor
There was a problem hiding this comment.
- Telefonica/mistica-design#2699 (review) needs changes, which in turn will have to be imported on this PR
- Feature looks inert: the generator is updated but the regenerated src/skins/*.tsx are not included, so no skin actually carries componentProperties. Everything falls back to the defaults (all true), meaning the vivo-evolution alternative behavior won't take effect. Could you regenerate and commit the skins?
- dismissActionType has no consumer — nothing reads it. Can we drop it and keep only showBoxedBorder?
Contributor
Author
|
Contributor
|
we first gotta wait for the Telefonica/mistica-design#2699 to be updated with the requested changes, and adapt this consequently. after that, feel free to re-request the review |
Marcosld
added
safe-to-deploy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: Telefonica/mistica-design#2669