Add Quantization Introduction and Bug Fix - #20
Merged
Conversation
Uxito-Ada
commented
Jul 29, 2026
| key_idx=2, | ||
| ignore_key=None, | ||
| linear_type="int8", | ||
| linear_dtype="int8", |
Collaborator
Author
There was a problem hiding this comment.
This change is because we have used linear_dytpe in docs, e.g. here, so changed the codes to make an alignment.
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation
Explain quantization clearly and fix bug
Type of Change
Changes Made
linear_typeargument tolinear_dtype, which was not aligned with CLI option and docs.Testing
pytest tests/)Test commands:
The targeted test run passed all 17 tests. The strict English and Chinese documentation build also passed.
Checklist
ruff)pre-commit run --all-files)pytest tests/)[TYPE] Brief descriptionRelated Issues
N/A
Additional Notes
GPU Architecture Support
N/A: this PR does not add or modify GPU kernels.