[refactor/#381] Post query/read model 책임 정리#393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❤️ 기능 설명
PostQueryService를 조회 orchestration 중심으로 단순화했습니다.PostReadModelEnricher를 도입해 keyword / bookmark / thumbnail enrichment를 row 단위 책임으로 분리했습니다.post패키지 테스트를@Nested구조로 정리하고, controller integration test를integration패키지로 이동했습니다.PostQueryService의 분기 선택 / cursor 계산 / auth 전달 회귀 테스트를 보강했습니다.테스트 결과는 아래 Gradle 실행으로 확인했습니다.
./gradlew test --tests '*PostQueryServiceTest' --tests '*PostReadModelEnricherTest' --tests '*PostKeywordLookupServiceTest' --tests '*PostLookupServiceTest'swagger 테스트 성공 결과 스크린샷 첨부
연결된 issue
연결된 issue를 자동으로 닫기 위해 아래 {이슈넘버}를 입력해주세요.
close #381
✅ 체크리스트