Fix the three findings the 0.22.0 self-check got wrong - #33
Merged
Merged
Conversation
… a rechecked split, split unit_outcome
Function splits of 20 lines or fewer, copies of up to twelve lines between test cases of different files, and splits the recheck raised from an undecided first answer (now asked their file's kind) were the three considers the 0.22.0 self-check got wrong. Every changed review and consider on the corpus was labeled: considers 57% to 59% right on tuned projects, 47% to 51% held out, 24% to 28% on blind Bend 2 ones. The baseline keeps only test_map's visit.
…aseline visit decided in one match both which classes hold test methods and which nodes are test cases. class_context now says what a class makes of its methods, and case what a node is to the walk (a case, a function that is not one, or something to look inside); visit only walks. With it the self-check reports no review or consider, so the last baseline entry is gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.22.0 release self-check baselined four considers as wrong. Three of them came from gaps in JevGate's own policy; this fixes those and measures each fix on the corpus, with every changed review and consider labeled by hand (a debatable one counts as not right).
Overall, considers went from 57% to 59% right on tuned projects, 47% to 51% held out and 24% to 28% on the blind Bend 2 set. No review changed except one wrong file-organization review, now gone. Rule versions are bumped, and the numbers are in the doc comments and CHANGELOG.
Also:
unit_outcomeis split into a dispatch and helpers (test_pair_outcome,workflows_outcome,staleness_outcome,settings_module_outcome,in_examples). The self-check flagged it once its file changed, and three rules' logic sat inline.The fourth,
test_map::visit, was a split consider no corpus measure separated from right ones (function length, the located block, a whole-body block). It is restructured instead:class_contextsays whether a class's methods are tests,casewhat a node is to the walk (a test case, a function that is not one, or something to look inside), andvisitonly walks. Behavior is unchanged (the test-map tests pass), and the baseline is now empty.Tests (478), clippy and
cargo +1.90.0 check --lockedpass. The self-check reports no review or consider.