Plan cached file purposes in a dry run - #24
Merged
Merged
Conversation
A dry run left files that need a file-purpose answer unplanned, even when the cache held that answer, so the units a run then sends for them were missing and requests that depend on them (tests, outlines) differed. On devise the estimate counted 106 of 1,532 first-pass requests as new while the run sent none. The preview now records a cached purpose and plans the file as a run does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dry run left files that need a file-purpose answer unplanned, even when the cache held that answer. The units a run then sends for those files were missing, and requests that depend on them (tests, outlines) differed, so a warm cache's estimate counted requests as new that the run answers from the cache.
On devise (evaluation corpus),
--dry-runcounted 106 of 1,532 first-pass requests as new; the real run sent none. With this change the dry run plans 1,640 requests, all answered by the cache, matching the run's 1,640 cache hits. lobsters, flask and spring-petclinic now plan more requests, all cached.previewrecords a cached purpose answer and plans the file asresolve_purposesdoes; an unanswered purpose still leaves the file unplanned, as documented.a_dry_run_plans_the_units_of_a_file_whose_purpose_the_cache_answers.