Keep the report's structure in a module of its own - #23
Merged
Merged
Conversation
schema/report.rs holds the report, file results, findings, dimensions and stage metrics; schema/mod.rs keeps the versions, statuses, answers, judgments and hashes and re-exports the rest, so no path changes. The self-check suggested the split.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release self-check flagged
src/schema.rs(file organization, consider, 0.87): its report types were a group of their own.schema/report.rsnow holds the report, file results, findings, locations, dimensions, stage metrics, scope levels, context needs and changes;schema/mod.rskeeps the versions, statuses, raw answers, judgments and hashes and re-exportsreport, so everycrate::schema::…path is unchanged. A pure move: tests pass unchanged, and the full self-check is back to the two baselined findings.