Fix: Coerce numeric dropdown/status/multiselect custom field values to strings - #406
Merged
Conversation
…o strings Setting a choice-based custom field value via create/update_custom_field_value failed for numeric input: the value was forwarded verbatim, so a JSON number reached the API where dropdown/status/multiselect choices are stored as strings, yielding "cannot unmarshal number ... into string" (dropdown custom fields could not be set through the connector at all). Resolve the field type and stringify the value for dropdown, status and multiselect fields before sending; number, checkbox, date and other types pass through unchanged. The field lookup only runs when the value actually carries a number, so the common string-value path adds no extra call. Also correct the misleading "option IDs for dropdown" wording in the value schema and allow numeric elements in the multiselect array branch. Adds a routed mock that captures the request body so tests assert the coerced wire payload. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Setting a choice-based custom field value via create/update_custom_field_value failed for numeric input: the value was forwarded verbatim, so a JSON number reached the API where dropdown/status/multiselect choices are stored as strings, yielding "cannot unmarshal number ... into string" (dropdown custom fields could not be set through the connector at all).
Resolve the field type and stringify the value for dropdown, status and multiselect fields before sending; number, checkbox, date and other types pass through unchanged. The field lookup only runs when the value actually carries a number, so the common string-value path adds no extra call. Also correct the misleading "option IDs for dropdown" wording in the value schema and allow numeric elements in the multiselect array branch.
Adds a routed mock that captures the request body so tests assert the coerced wire payload.
Type of Change
Testing
go test -v ./...)Checklist