Skip to content

fix: 친구 토너먼트 결과에서 선택받지 않은 후보 제외 - #574

Merged
ychany merged 1 commit into
devfrom
fix/572-group-result-chosen-only
Aug 25, 2026
Merged

fix: 친구 토너먼트 결과에서 선택받지 않은 후보 제외#574
ychany merged 1 commit into
devfrom
fix/572-group-result-chosen-only

Conversation

@ychany

@ychany ychany commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

작업 내용

친구 토너먼트 결과 영수증에 아무도 선택하지 않은 후보까지 노출되던 문제를 수정했습니다.

  • chosenBy 가 비어 있는 상품을 목록에서 제외 (1st Place · Others 모두 적용)
  • 선택받은 상품이 하나도 없으면 기존 아직 친구 결과가 없어요 안내로 처리 — 로고만 남은 빈 영수증이 나오지 않도록

rank 는 선택 인원 순위이므로 1st Place(가장 많이 선택받은 상품)와 Others(그다음 선택받은 상품들) 구조는 그대로 유지됩니다.

연관 이슈

closes #572

@vercel

vercel Bot commented Aug 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
piki Ready Ready Preview Aug 25, 2026 1:40pm

@github-actions github-actions Bot added fix Something isn't working WEB labels Aug 25, 2026
@github-actions

Copy link
Copy Markdown

Discord 스레드 연동용 메타데이터입니다. discord-pr-bot 워크플로가 자동 생성하며, 수정·삭제하면 PR 과 Discord 알림 연동이 끊깁니다.

@github-actions
github-actions Bot requested a review from iOdiO89 August 25, 2026 13:41
@ychany
ychany merged commit 3d868e1 into dev Aug 25, 2026
9 checks passed
@ychany
ychany deleted the fix/572-group-result-chosen-only branch August 25, 2026 13:45
@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 54 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 95906468-57c3-406a-9b50-7bd3ebe9a534

📥 Commits

Reviewing files that changed from the base of the PR and between f45492a and f001bbf.

📒 Files selected for processing (1)
  • apps/web/src/app/tournament/[id]/result/group/_components/GroupResultClient.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Something isn't working WEB

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: 친구 토너먼트 결과에 선택받지 않은 후보까지 노출됨

1 participant