Repository navigation
[FEAT] 온보딩 캘린더 연동 단계 재활성화 및 Apple 캘린더 연동 UI 추가 #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ehye1
wants to merge
20
commits into
develop
Choose a base branch
from
feat/web/299-onboarding-calendar-connect-step
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
2117dc5
refactor(web): 캘린더 연동 origin을 상수로 분리하고 사용 후 삭제하도록 수정 (#299)
ehye1 9c003a8
refactor(web): 로그인·캘린더 연동 버튼을 전역 AuthButton으로 이동하고 variant 정리 (#299)
ehye1 d6dd978
feat(web): 온보딩 캘린더 연동 단계 재활성화 (#299)
ehye1 212f033
fix(web): 온보딩 카드 레이아웃을 피그마 간격에 맞게 수정 (#299)
ehye1 b45c03e
feat(web): 캘린더 연동 실패 시 토스트 표시 (#299)
ehye1 233a9e7
feat(web): Apple 캘린더 연동 UI 추가 및 로고 이미지를 svg로 교체 (#299)
ehye1 3b18e87
fix(web): 로고 이미지를 png로 되돌리고 선명하게 표시 (#299)
ehye1 b0f7826
refactor(web): 설정 캘린더 줄을 SettingsCalendar 컴포넌트로 분리 (#299)
ehye1 642d9a5
refactor(web): 온보딩 4단계 시작 시 불필요한 답변 검사 제거 (#299)
ehye1 8983e45
fix(web): 캘린더 연동 예외 상황 처리 (#299)
ehye1 fb11565
fix(web): 온보딩 단계 숫자 중앙 정렬 수정 (#299)
ehye1 a00ed4f
fix(web): 설정 캘린더 연동 박스 너비 통일 (#299)
ehye1 ae8e90c
refactor(web): 캘린더 연동 출발지를 sessionStorage 유틸로 분리 (#299)
ehye1 ad92ec9
fix(web): 온보딩 답변·연동 실패 기록의 저장소 접근 예외 처리 (#299)
ehye1 47f94ec
chore(web): 캘린더 authorize API에 redirectOrigin 파라미터 반영 (#299)
ehye1 c08dca2
feat(web): 캘린더 연동 시 현재 origin을 redirectOrigin으로 전달 (#299)
ehye1 9e79d87
feat(ui): PillButton이 버튼 HTML 속성을 받도록 확장 (#299)
ehye1 57ca316
fix(web): 설정 캘린더 연동 버튼에 캘린더 이름을 포함한 aria-label 추가 (#299)
ehye1 dc4c790
fix(web): 설정 캘린더 연동 버튼 aria-label 되돌리기 (#299)
ehye1 22c14f6
refactor(ui): PillButton HTML 속성 확장 되돌리기 (#299)
ehye1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
38 changes: 38 additions & 0 deletions
38
apps/timo-web/app/[locale]/(main)/settings/_components/account/SettingsCalendar.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| import { PillButton } from "@repo/timo-design-system/ui"; | ||
| import Image from "next/image"; | ||
|
|
||
| interface SettingsCalendarProps { | ||
| iconSrc: string; | ||
| name: string; | ||
| isConnected: boolean; | ||
| connectLabel: string; | ||
| disconnectLabel: string; | ||
| onClick: () => void; | ||
| } | ||
|
|
||
| export const SettingsCalendar = ({ | ||
| iconSrc, | ||
| name, | ||
| isConnected, | ||
| connectLabel, | ||
| disconnectLabel, | ||
| onClick, | ||
| }: SettingsCalendarProps) => { | ||
| return ( | ||
| <div className="bg-timo-gray-300 flex h-10.25 w-[243px] items-center justify-between gap-4 self-start rounded-lg px-2.5 py-1.5"> | ||
| <div className="flex items-center gap-1.5"> | ||
| <Image src={iconSrc} alt="" width={20} height={20} unoptimized /> | ||
| <span className="typo-headline-m-16 text-timo-gray-700 whitespace-nowrap"> | ||
| {name} | ||
| </span> | ||
| </div> | ||
|
|
||
| <PillButton | ||
| variant={isConnected ? "gray-dark" : "blue"} | ||
| onClick={onClick} | ||
| > | ||
| {isConnected ? disconnectLabel : connectLabel} | ||
| </PillButton> | ||
| </div> | ||
| ); | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
선택적인 접근성 개선 의견입니다! 버튼 구분을 위해 aria-label에 Google·Apple 이름도 넣어주면 어떨까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
현재 PillButton이 aria 속성을 받지 않아서 공용 Button으로 교체할 때 aria-label에 구글/애플 이름을 함께 넣도록 반영하겠습니다! 👍