Skip to content

로그 위생 정리 및 레이어별 로깅 규칙 적용 #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ckdals4600 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

로그 위생 정리 및 레이어별 로깅 규칙 적용 #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/main/java/com/sofa/linkiving/domain/chat/ai/MockAnswerClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,12 @@
import com.sofa.linkiving.domain.chat.dto.request.RagAnswerReq;
import com.sofa.linkiving.domain.chat.dto.response.RagAnswerRes;

import lombok.extern.slf4j.Slf4j;

@Slf4j
@Component
@Profile("test")
public class MockAnswerClient implements AnswerClient {

@Override
public RagAnswerRes generateAnswer(RagAnswerReq request) {
log.info("[Mock AI Request] User: {}, Question: {}, Mode: {}, HistoryCnt: {}",
request.userId(), request.question(), request.mode(), request.history().size());

return new RagAnswerRes(
"임시 답변",
List.of("3", "4"),
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/com/sofa/linkiving/domain/chat/facade/ChatFacade.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ public void generateAnswer(Long chatId, Member member, String message) {
if (task.isCancelled() || ex != null) {

if (ex != null) {
log.error("AI 답변 생성 중 오류 발생 - chatId: {}, error: {}", chatId, ex.getMessage(), ex);
log.error("AI 답변 생성 중 오류 발생 - chatId={}", chatId, ex);
} else {
log.info("AI 답변 생성 작업 취소됨 - chatId: {}", chatId);
log.info("AI 답변 생성 작업 취소됨 - chatId={}", chatId);
}

sendNotification(chatId, member, AnswerRes.error(chatId, message));
Expand All @@ -92,7 +92,7 @@ public void generateAnswer(Long chatId, Member member, String message) {
return;
}

log.error("AI 답변 생성 결과가 null 입니다 - chatId: {}", chatId);
log.error("AI 답변 생성 결과가 null 입니다 - chatId={}", chatId);
sendNotification(chatId, member, AnswerRes.error(chatId, message));
});
}
Expand Down
5 changes: 3 additions & 2 deletions src/main/java/com/sofa/linkiving/domain/link/event/SummaryStatusEventListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ public void handleSummaryStatusEvent(SummaryStatusEvent event) {
"/queue/summary",
event.response()
);
log.info("요약 상태 웹소켓 푸시 완료 - 이메일: {}, 상태: {}, 링크ID: {}",
event.email(), event.response().status(), event.response().linkId());

log.debug("요약 상태 웹소켓 푸시 완료 - status={}, linkId={}",
event.response().status(), event.response().linkId());
}
}
10 changes: 5 additions & 5 deletions src/main/java/com/sofa/linkiving/domain/link/service/LinkService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public Link createLink(Member member, String url, String title, String memo, Str
}

Link link = linkCommandService.saveLink(member, url, title, memo, imageUrl);
log.info("Link created - id: {}, memberId: {}, url: {}", link.getId(), member.getId(), url);
log.info("Link created - id={}, memberId={}", link.getId(), member.getId());

return link;
}
Expand All @@ -38,7 +38,7 @@ public Link updateLink(Long linkId, Member member, String title, String memo, St
Link link = linkQueryService.findById(linkId, member);
Link updatedLink = linkCommandService.updateLink(link, title, memo, imageUrl);

log.info("Link updated - id: {}, memberId: {}", linkId, member.getId());
log.debug("Link updated - id={}, memberId={}", linkId, member.getId());

return updatedLink;
}
Expand All @@ -47,7 +47,7 @@ public Link updateTitle(Long linkId, Member member, String title) {
Link link = linkQueryService.findById(linkId, member);
Link updatedLink = linkCommandService.updateLink(link, title, link.getMemo(), link.getImageUrl());

log.info("Link title updated - id: {}, memberId: {}", linkId, member.getId());
log.debug("Link title updated - id={}, memberId={}", linkId, member.getId());

return updatedLink;
}
Expand All @@ -56,7 +56,7 @@ public Link updateMemo(Long linkId, Member member, String memo) {
Link link = linkQueryService.findById(linkId, member);
Link updatedLink = linkCommandService.updateLink(link, link.getTitle(), memo, link.getImageUrl());

log.info("Link memo updated - id: {}, memberId: {}", linkId, member.getId());
log.debug("Link memo updated - id={}, memberId={}", linkId, member.getId());

return updatedLink;
}
Expand All @@ -65,7 +65,7 @@ public void deleteLink(Long linkId, Member member) {
Link link = linkQueryService.findById(linkId, member);
linkCommandService.deleteLink(link);

log.info("Link soft deleted - id: {}, memberId: {}", linkId, member.getId());
log.info("Link soft deleted - id={}, memberId={}", linkId, member.getId());
}

public Link getLink(Long linkId) {
Expand Down
3 changes: 1 addition & 2 deletions src/main/java/com/sofa/linkiving/domain/link/util/OgTagCrawler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public OgTagCrawler(UrlValidator urlValidator) {
}

public OgTagDto crawl(String url) {
// SSRF 방어: URL 안전성 검증
urlValidator.validateSafeUrl(url);

try {
Expand All @@ -39,7 +38,7 @@ public OgTagDto crawl(String url) {
.build();

} catch (IOException e) {
log.warn("OG 태그 크롤링 실패: {}", url, e);
log.warn("OG 태그 크롤링 실패 - url={}, reason={}", url, e.getMessage());
return OgTagDto.EMPTY;
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/sofa/linkiving/domain/link/worker/SummaryQueue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public class SummaryQueue {
*/
public void addToQueue(Long linkId) {
summaryQueue.offer(linkId);
log.info("Link added to summary queue - linkId: {}", linkId);
log.debug("Link added to summary queue - linkId={}", linkId);
}

/**
Expand Down
5 changes: 3 additions & 2 deletions src/main/java/com/sofa/linkiving/infra/s3/S3ImageUploader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ private String uploadNewImage(String originalUrl) {
log.warn("Invalid image URL skipping upload: {}", originalUrl);
return normalizedDefaultImageUrl();
} catch (Exception e) {
log.error("S3 upload failed for URL: {}", originalUrl, e);
log.warn("S3 upload failed, fallback to default image - url={}, reason={}",
originalUrl, e.getMessage());
return normalizedDefaultImageUrl();
}
}
Expand All @@ -92,7 +93,7 @@ public Optional<String> resolveStoredUrl(String originalUrl) {
try {
String s3Key = generateUniqueKeyFromUrl(originalUrl);
if (s3Template.objectExists(bucketName, s3Key)) {
log.info("Image already exists (Cache Hit): {} -> {}", originalUrl, s3Key);
log.debug("Image cache hit - s3Key={}", s3Key);
return Optional.of(buildS3Url(s3Key));
}
} catch (Exception e) {
Expand Down
6 changes: 6 additions & 0 deletions src/main/java/com/sofa/linkiving/security/auth/handler/OAuth2FailureHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@
import jakarta.servlet.http.HttpServletRequest;
import jakarta.servlet.http.HttpServletResponse;
import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;

@Slf4j
@Component
@RequiredArgsConstructor
public class OAuth2FailureHandler extends SimpleUrlAuthenticationFailureHandler {
Expand All @@ -39,6 +41,10 @@ public void onAuthenticationFailure(HttpServletRequest request, HttpServletRespo
errorCode = determineAuthErrorCode(error.getErrorCode());
}

if (errorCode.getStatus().is5xxServerError()) {
log.warn("OAuth 로그인 실패(서버성 오류) - code={}", errorCode.getCode());
}

String targetUrl = UriComponentsBuilder.fromUriString(oauth2Properties.failureRedirectUrl())
.queryParam("code", errorCode.getCode())
.build().toUriString();
Expand Down
1 change: 0 additions & 1 deletion src/main/java/com/sofa/linkiving/security/jwt/JwtTokenProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ public String resolveToken(HttpServletRequest request) {
return cookie.getValue();
}

log.warn("Token not found (missing in both header and cookie)");
return null;
}

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/sofa/linkiving/security/jwt/error/JwtErrorCode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public enum JwtErrorCode implements ErrorCode {
UNSUPPORTED_JWT_TOKEN(HttpStatus.UNAUTHORIZED, "J-002", "지원하지 않는 JWT 토큰입니다."),
EMPTY_TOKEN(HttpStatus.UNAUTHORIZED, "J-003", "토큰이 필요합니다."),
CANNOT_REFRESH(HttpStatus.UNAUTHORIZED, "J-004", "토큰을 갱신할 수 없습니다."),
INVALID_REFRESH(HttpStatus.BAD_REQUEST, "J-004", "refresh 토큰이 아닙니다.");
INVALID_REFRESH(HttpStatus.BAD_REQUEST, "J-005", "refresh 토큰이 아닙니다.");

private final HttpStatus status;
private final String code;
Expand Down