prod 로그 레벨/프로필 drift 제거 및 SQL 바인딩 로그 차단#251
Open
Goder-0 wants to merge 1 commit into
Open
Conversation
📊 코드 커버리지 리포트
|
ckdals4600
reviewed
Jun 26, 2026
ckdals4600
left a comment
Contributor
There was a problem hiding this comment.
prod 프로필에 Hibernate SQL/bind 로거를 명시적으로 OFF 처리한 부분 잘 반영된 것 같습니다.
다만 노션에서 관리되고 있는 환경 설정 파일은 그대로라 해당 파일에 대해서도 아래와 같은 수정이 필요할 것 같습니다.
spring.jpa.show-sql: true→false(이건 System.out 직출력이라 logback으로는 막히지 않습니다.)logging.level.org.hibernate.SQL: debug→ 제거 또는 OFFlogging.level.org.hibernate.orm.jdbc.bind: trace→ 제거 또는 OFF
logging.level은 logback-spring.xml보다 나중에 적용돼서 logback의 OFF를 덮어씁니다.
그래서 이 두 줄이 남아 있으면 logback을 아무리 막아도 prod에서 다시 적용될 우려가 있습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈
PR 설명
Overview
Changes
logback-spring.xml의prodprofile에 아래 로거를OFF로 추가org.hibernate.SQLorg.hibernate.type.descriptor.sql.BasicBinderorg.hibernate.orm.jdbc.bindNotes