Repository navigation
fix(settings): dual-persistence, atomic save, and property watcher coverage - #159
Open
berlin-566 wants to merge 1 commit into
Open
berlin-566 wants to merge 1 commit into
berlin-566 wants to merge 1 commit into
Conversation
…verage for sound and shell settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes settings persistence issues across reboots/reloads (notably sound effects toggling back on by itself) and enhances overall configuration durability and reliability.
Key Changes
Dual-Persistence Architecture:
~/.config/agility-shell/settings_prefs.json(durable user config) and automatically mirrors to~/.cache/quickshell/settings_prefs.jsonand/var/tmp/sddm-theme/settings_prefs.jsonfor backwards compatibility withaglCLI,agilityd, and SDDM.~/.config/agility-shell/.~/.config/agility-shell/.Atomic Writing & Backup Safeguards:
save_settings.pywhich writes to a temporary file, flushes (os.fsync), sets0644permissions, and atomically renames (os.replace) while keeping a.bakbackup file to prevent JSON corruption on power-off or crash.read_settings.pyfor safe fallback parsing across primary config, cache, and.bakbackups.Complete Property Watcher Coverage:
SettingsService.qmlandHyprlandService.qml:soundEffectsEnabled(resolves sound effects turning back on after closing settings)pillBarThicknessbluetoothOnStartupbarIconMode,barIconShape,barIconCycleShapes,barIconCycleInterval,barIconCustomSvgbarOpenOnHover,barSolidTonewpClicksEnabled,wpSourceMode,wpCustomFolderPathBinding on checkedacrossEffectsSettings.qml,BarSettings.qml,BarAppletsSettings.qml, andIntegrationsSettings.qmlto prevent UI toggle state drift.Rust CLI and Daemon Durability:
crates/agility-cliandcrates/agilitydto check the durable config store first with cache fallback.Theme.qmlto mirror colorschemes to~/.config/agility-shell/colorscheme.json.Verification
cargo checkbuilds with 0 errors.