Repository navigation
feat(sounds): fix audio playback engine, wire battery/window chimes & add audition preview - #156
Merged
Merged
Conversation
added 3 commits
October 21, 2026 23:06
…eedback - Replace dynamic Process allocation/destruction in SoundService with persistent 4-slot Process pool - Add direct PipeWire (pw-play) and PulseAudio (paplay) execution with search path fallbacks - Add battery state transitions to SystemInfoService: battery-charge on plug-in, battery-warning on unplug and 20% threshold, battery-low at 10% - Wire widget-placed and widget-removed for standalone windows (Settings, PackageManager) in WidgetLoader - Add Audition Sound Theme 'Test Sound' button to EffectsSettings - Add confirm audio chime on custom shortcut addition
…omodoro timer with alarm sound
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request resolves the issue where system sound effects were not playing, fixes the underlying audio playback engine, connects missing battery and window audio events, and adds a sound audition button in Settings.
1. Root Cause & Sound Engine Fix
SoundService.qmlused dynamicsoundComp.createObject()combined withonRunningChanged: if (!running) procItem.destroy(). Becauserunningstarts atfalseupon object instantiation, this caused premature object destruction before the process could spawn or complete.Processrunners (p0–p3), allowing instant, zero-latency, concurrent audio playback without memory churn.pw-play) with automated fallback to PulseAudio (paplay), ALSA (aplay), andagl sound play.~/.config/agility-shell/sounds/), system directory (/usr/share/agility-shell/sounds/), and local repository paths (../../sounds/).2. Comprehensive Shell Sound Coverage
session-start: Plays startup chime on shell/session launch.session-quit: Plays on system lock engagement, power menu actions, and shutdown.battery-charge: Triggers automatically when AC power adapter is plugged in (batteryStatustransitions to'Charging').battery-warning: Triggers when AC power is unplugged (batteryStatustransitions to'Discharging') or battery drops to the 20% warning threshold.battery-low: Triggers when battery drops to the critical 10% threshold.widget-placed&widget-removed: Wired across all popups, widgets, applets, and standalone windows (Settings,PackageManager,Keybinds) viaWidgetLoaderandAppState.notification: Plays on incoming desktop notifications inNotificationService.confirm: Plays on lockscreen unlock, screenshot completion, and adding custom keyboard shortcuts.error: Plays on lockscreen authentication failures.3. Settings UI Enhancement