Skip to content

feat: Learning Hub - Milestone 1 #2341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
camielvs wants to merge 1 commit into
base: 05-19-feat_learning_hub_tip_of_the_day
Choose a base branch
from
Draft

feat: Learning Hub - Milestone 1 #2341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions src/routes/Dashboard/Learn/LearnHomeView.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,15 +56,15 @@ describe("<LearnHomeView/>", () => {
).toBeInTheDocument();
});

test("renders the onboarding hero with progress", () => {
renderWithClient(<LearnHomeView />);
expect(
screen.getByRole("heading", { level: 2, name: /welcome to tangle/i }),
).toBeInTheDocument();
expect(
screen.getByRole("progressbar", { name: /onboarding progress/i }),
).toBeInTheDocument();
});
// test("renders the onboarding hero with progress", () => {
// renderWithClient(<LearnHomeView />);
// expect(
// screen.getByRole("heading", { level: 2, name: /welcome to tangle/i }),
// ).toBeInTheDocument();
// expect(
// screen.getByRole("progressbar", { name: /onboarding progress/i }),
// ).toBeInTheDocument();
// });

test("renders the docs quicklinks and full-docs link at the top", () => {
renderWithClient(<LearnHomeView />);
Expand All @@ -78,9 +78,9 @@ describe("<LearnHomeView/>", () => {
expect(
screen.getByRole("heading", { level: 3, name: /tip of the day/i }),
).toBeInTheDocument();
expect(
screen.getByRole("heading", { level: 3, name: /featured tours/i }),
).toBeInTheDocument();
// expect(
// screen.getByRole("heading", { level: 3, name: /featured tours/i }),
// ).toBeInTheDocument();
expect(
screen.getByRole("heading", { level: 2, name: /example pipelines/i }),
).toBeInTheDocument();
Expand Down
8 changes: 6 additions & 2 deletions src/routes/Dashboard/Learn/LearnHomeView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ import { OnboardingHero } from "@/components/Learn/OnboardingHero";
import { TipOfTheDay } from "@/components/Learn/TipOfTheDay";
import { BlockStack } from "@/components/ui/layout";

// Learning Hub Milestone 1: Documentation, FAQ, Example Pipelines & Tips
// Not included: Guided Tours & Onboarding
const DO_NOT_RELEASE = false;

export function LearnHomeView() {
return (
<BlockStack gap="6">
Expand All @@ -24,11 +28,11 @@ export function LearnHomeView() {
</BlockStack>
</BlockStack>

<OnboardingHero />
{DO_NOT_RELEASE && <OnboardingHero />}

<div className="grid grid-cols-1 lg:grid-cols-2 gap-4">
<TipOfTheDay />
<FeaturedTours />
{DO_NOT_RELEASE && <FeaturedTours />}
</div>

<FeaturedExamples />
Expand Down
Loading