Skip to content

test: cover SVG coordinate changes between pointer samples #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannerlinsley merged 1 commit into from
Oct 14, 2026
Merged

test: cover SVG coordinate changes between pointer samples #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benchmarks/conformance/previews/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"schemaVersion": 1,
"width": 288,
"height": 192,
"sourceHash": "b503388bda59296b32222df9ec499915bd86d0c8d93852609d596973cfd21f71",
"sourceHash": "2ce2590f5c943219b694d3c51bb4806ed785ff0a4058c108fc520b0e6087c183",
"assets": [
{
"id": "01-line-gaps",
Expand Down
35 changes: 28 additions & 7 deletions packages/charts-core/src/svg-surface.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ describe('SVG surface coordinates', () => {
surface.destroy()
})

it('maps client coordinates through the rendered SVG transform', () => {
it('refreshes the rendered SVG transform between coordinate samples', () => {
const scene = createChartScene(
defineChart({
marks: [dot([{ x: 1, y: 1 }], { x: 'x', y: 'y' })],
Expand All @@ -352,6 +352,8 @@ describe('SVG surface coordinates', () => {
const renderedHeight = 480
const scale = renderedWidth / scene.width
const verticalInset = (renderedHeight - scene.height * scale) / 2
let translationX = 0
let translationY = 0

vi.spyOn(svg, 'getBoundingClientRect').mockReturnValue(
DOMRect.fromRect({
Expand All @@ -363,16 +365,17 @@ describe('SVG surface coordinates', () => {
)
Object.defineProperty(svg, 'getScreenCTM', {
configurable: true,
value: vi.fn(() => ({
inverse: () => ({
value: vi.fn(() => {
const inverse = {
a: 1 / scale,
b: 0,
c: 0,
d: 1 / scale,
e: -left / scale,
f: -(top + verticalInset) / scale,
}),
})),
e: -(left + translationX) / scale,
f: -(top + verticalInset + translationY) / scale,
}
return { inverse: () => inverse }
}),
})

const expected = { x: 603.84, y: 28.76 }
Expand All @@ -385,6 +388,24 @@ describe('SVG surface coordinates', () => {
expect(resolved?.x).toBeCloseTo(expected.x)
expect(resolved?.y).toBeCloseTo(expected.y)

// Ancestor transforms, preceding layout and scroll can move the SVG
// without resizing it or rendering another chart scene.
for (const { x, y } of [
{ x: 40, y: 30 },
{ x: 0, y: 75 },
{ x: 0, y: -50 },
]) {
translationX = x
translationY = y
const moved = surface.clientToScene?.(
scene,
left + translationX + expected.x * scale,
top + verticalInset + translationY + expected.y * scale,
)
expect(moved?.x).toBeCloseTo(expected.x)
expect(moved?.y).toBeCloseTo(expected.y)
}

surface.destroy()
})

Expand Down