Repository navigation
perf: skip sunburst boundary sampling during animation - #224
Conversation
🦋 Changeset detectedLatest commit: e9e894f The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
|
View your CI Pipeline Execution ↗ for commit e9e894f
☁️ Nx Cloud last updated this comment at |
|
Follow-up timing check: the short nested scene-build samples differed by 0.1 to 0.2 ms across ten builds, so I repeated with 100 builds per sample. Two seven-pair runs measured median 91.9 to 91.6 ms and 87.1 to 87.6 ms. The small difference changed direction, so these measurements do not establish a repeatable scene-build regression. Thirty animation frames remained faster in both runs: 27.9 to 22.8 ms and 27.6 to 22.6 ms. All four CI stress partitions and all four comparison partitions have passed; static checks and review are still running. |
Change
Sunburst animation frames only need an SVG path, but were also rebuilding sampled hit-test boundaries. Separate path projection from boundary sampling and reuse the existing D3 arc defaults. Initial scene construction still builds interaction boundaries.
Found while investigating the polar animation report from @toomingos in #194. This does not resolve that issue or include the held rounded-arc changes.
Verification
Includes a patch Changeset. No public API or dependency changes.
Summary by CodeRabbit