Skip to content

feat: record the model and outcome of every AI round on the PR - #28

Merged
george-elphick-talieisin merged 2 commits into
mainfrom
feat/record-model-marker
Sep 21, 2026
Merged

george-elphick-talieisin merged 2 commits into
mainfrom
feat/record-model-marker

Conversation

@george-elphick-talieisin

@george-elphick-talieisin george-elphick-talieisin commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • The model behind each AI round only appeared in Actions logs, which GitHub deletes after a while, so there was no way to judge the model tiering from feat: tier Claude models by task in the upgrade pipeline #26 over time. Each round now resolves its model once (a pick step that --model reads), and every comment or review it posts carries a hidden <!-- ai-meta v=1 run=… round=… mode=… model=… --> marker plus a visible Model: line.
  • The step that sets a run's terminal label also writes <!-- ai-outcome v=1 run=… outcome=… -->: ci-watch, the decide/suggest park paths, suggest success, requeues, the finalize crash path, and the Copilot-response CI result. Outcomes are recorded by the run itself because labels change later for unrelated reasons (the Copilot-response CI result, the dispatcher's stale-green check).
  • On a retry, the status comment carries earlier runs' marker lines forward, so no run's record is lost. The markers feed a fortnightly model-tier report (companion PR in Talieisin/automation). The plan was reviewed by Codex (plan review plus recheck; all findings addressed).

Test plan

  • actionlint shows no new findings compared with main (only shifted line numbers on existing SC2016 notices)
  • bash -n on every run: block in both workflows
  • Simulated the real step scripts with a stubbed gh: requeue → push → ci-watch success → retry blocked keeps all markers in order; a gate-blocked run adds none; a suggest park and a no-push Copilot round are both marked correctly
  • The next live pipeline run carries ai-meta and ai-outcome with the same run=, and the model matches --model in that run's log

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Each round resolves its model once (pick step) and every comment it
posts carries an ai-meta marker (run id, round, mode, model); the step
that sets the terminal label writes an ai-outcome marker for the same
run. The status comment carries earlier runs' markers forward on a
retry. Read by the model-tier report in Talieisin/automation.
Copilot AI lite review requested due to automatic review settings September 21, 2026 22:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Unresolved metadata-schema, failure-outcome, and requeue-recording issues remain.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 High severity · 2 Medium severity

Open (3)
What changed in this PR

Adds persistent model and outcome metadata to Dependabot and Copilot-response workflow rounds.

Changes:

  • Resolves and records the model used for each AI round.
  • Adds hidden metadata markers and visible model attribution.
  • Preserves metadata across retries and records terminal outcomes.
File Summary
.github/​workflows/​dependabot-upgrade.yml Records round models and upgrade outcomes.
.github/​workflows/​copilot-response.yml Records Copilot-response models and CI outcomes.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/dependabot-upgrade.yml
Comment thread .github/workflows/copilot-response.yml Outdated
Comment thread .github/workflows/dependabot-upgrade.yml Outdated
@george-elphick-talieisin
george-elphick-talieisin merged commit 1b24776 into main Sep 21, 2026
1 check passed
@george-elphick-talieisin
george-elphick-talieisin deleted the feat/record-model-marker branch September 21, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants