fix: final-outcome step crashed on every successful non-rescue run - #27
Merged
Merged
Conversation
Copilot started reviewing on behalf of
george-elphick-talieisin
September 21, 2026 22:30
View session
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The change correctly prevents set -e from aborting the success path and is narrowly scoped with no additional behavioral risk observed.
Review effort: Lite
Findings: None
What changed in this PR
Fixes a bash set -euo pipefail interaction in the ci-watch “Record final outcome” step so successful non-rescue runs no longer crash before applying the terminal label/message.
Changes:
- Prevents a non-rescue success path from exiting due to a failing command substitution by forcing a zero exit status (
|| true) inside the substitution.
| File | Description |
|---|---|
| .github/workflows/dependabot-upgrade.yml | Ensures the success message construction can’t terminate the step under set -e, allowing the final label/message to be applied consistently. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci-watch→ "Record final outcome" has crashed on every successful non-rescue run. The success message runs$([ "$MODE" = "rescue" ] && echo …), which returns 1 when the mode isn't rescue. Underset -euo pipefail, that failing substitution in an assignment ends the step before any label is set.finalizethen seesai-upgradestill present and parks the PR asai-blocked("ended without reaching a terminal state"), so CI-green upgrades land in the needs-a-decision list instead of the ready-to-merge one.OUTCOME: success,MODE: upgrade) and Talieisin/macwhisper-assistant#71 (run 35523851554). Fix:|| trueinside the substitution. This is the only occurrence of the pattern in either repo.Test plan
set -euo pipefailwithMODE=upgrade; the fixed line gives the right message forupgradeandrescueai-completeNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.