Repository navigation
fix(widget): default apiBaseUrl to the production origin - #18
Merged
Merged
Conversation
When apiBaseUrl was omitted, the SDK fell back to https://app.supo.com, which is not a Supo server. It now falls back to https://supo.muhammadtahubkhatri.dev (PRODUCTION_ORIGIN), and a test keeps the two in sync. resolveApiBaseUrl no longer reads document.currentScript. For npm usage that can be the host page's own classic-script bundle, which sent requests to the customer's site. The widget.js embed now captures its loader origin itself. Bumps @supoapp/widget to 0.1.0-alpha.11 (not published).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apiBaseUrl: whenapiBaseUrlis omitted,@supoapp/widgetnow callshttps://supo.muhammadtahubkhatri.dev(PRODUCTION_ORIGIN). The old default,https://app.supo.com, isn't a Supo server, so every request failed.document.currentScriptguessing in npm entry points:resolveApiBaseUrlno longer reads it. WheninitSuporan at the top level of a classic-script bundle (webpack, Next.js chunks), that was the host site's own script, so requests went to the customer's site.widget.jsscript embed: it now records the origin it was loaded from at load time (legacy-global.ts). Precedence is the same as before: explicitapiBaseUrl, then script origin, then the default.packages/widget/src/runtime/__tests__/config.test.ts. A new check intrusted-origins.test.tskeeps the SDK default equal toPRODUCTION_ORIGIN.@supoapp/widgetbumped to0.1.0-alpha.11, with entries in both changelogs. The README and docs page now describe the default.public/widget.jsis rebuilt.WidgetConfigurator.tsxare unchanged: they passapiBaseUrlexplicitly, and its "Local dev" note already describes this behaviour.Publishing to npm is a separate manual step:
bun run --cwd packages/widget release:alpha.Testing
bun run typecheck:sdkbun run test(159 passed, 42 DB integration tests skipped withoutTEST_DATABASE_URL)bun run typecheckbun run lintbun run build:legacy-widgetGenerated by Claude Code