Repository navigation
feat: verify Neon readiness and add transfer review - #44
Conversation
# Conflicts: # docs/HANDOFF.md
# Conflicts: # AGENTS.md # docs/HANDOFF.md
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e29daf0eb3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| isTransfer: true, | ||
| transferPairId: uuidv7(), | ||
| updatedAt: new Date(), |
There was a problem hiding this comment.
Preserve reviewed pairings across Nessie syncs
When either selected row is Nessie-backed, this user-generated pair ID is treated as drift by the existing sync: src/features/nessie/domain/diff.ts compares both transfer fields, and src/features/nessie/server/sync.ts:157-188 rewrites them from Nessie. The next Sync therefore silently removes a confirmed pairing—or restores a pairing the user detached—and a mixed Nessie/CSV pair leaves the other row orphaned. Preserve review provenance or make Nessie sync retain user-reviewed classification.
Useful? React with 👍 / 👎.
| @@ -0,0 +1,154 @@ | |||
| .page { | |||
| max-width: 70rem; | |||
| padding: clamp(1.5rem, 3vw, 2.5rem) clamp(1rem, 3vw, 3rem) 3rem; | |||
There was a problem hiding this comment.
Replace hardcoded transfer-review sizing with shared tokens
The new CSS module hard-codes spacing and type sizes throughout (rem, px, and clamp(...)) instead of consuming the shared custom properties. Move these values into src/app/globals.css and reference the resulting tokens here so this component follows the repository's required theming convention.
AGENTS.md reference: AGENTS.md:L184-L188
Useful? React with 👍 / 👎.
# Conflicts: # docs/HANDOFF.md
Summary
Adds explicit review of recorded transfers and card repayments from Transactions. Confirmation pairs two owned records atomically; detaching keeps their labels, and classification preserves recorded account balances and cashflow balance history.
Adds a read-only
db:verifycommand for the financial schema and SELECT access, runs it after migrations in CI, and supports optional Neon WebSockets in environments that block TCP. PostgreSQL TCP remains the default; statement storage uses the configured private Neon bucket.Feature / bug
Database readiness and recorded transfer review. Previously, manually classifying a card repayment could change the displayed historical opening balance; transfer movements now retain their balance effects while remaining excluded from spending and income.
Governing ADRs
ADR-008, ADR-020, ADR-049, ADR-050, ADR-053, and new ADR-066.
Type
Definition of done (AGENTS.md section 8)
Follows every non-negotiable rule in AGENTS.md section 4
Vitest tests for domain logic, including edge cases
Playwright test for the user-facing flow
Workspace isolation matrix updated if a new server action or route was added
Lint, typecheck, unit and E2E pass locally
Docs updated; HANDOFF entry appended
Before the final refresh from
main(5a60b11), 2,685 unit/integration tests in 138 files pass, including real Neon test storage. Coverage thresholds are unchanged (91.90% lines, 89.09% branches).At that same base, 131 non-external Playwright tests pass against the production build, including all eight transfer flows; four workers, a 60-second test timeout, and an isolated local database.
After merging
main5116fb5, all 544 affected unit/integration checks and 33 affected browser checks pass, covering transfers, alerts, messaging, authorization, readiness, navigation and categorization.Lint, formatting, app/worker typechecks, docs consistency, production build, bundle scan, and diff checks pass.
The configured Neon app and local financial-schema/SELECT preflights report READY. Production migration-journal discrepancies remain diagnostic warnings.
Parallel browser groups now create fresh Budgets, categorization and alerts seed pools instead of reusing closed pools. A transient storage timeout passed on retry; the final complete unit suite passes with its original timeouts. The navigation test waits for each clicked link to hydrate; browser assertions remain intact. One readiness CLI test exceeded its five-second timeout under concurrent build load; all 21 readiness tests passed on separate retry with that timeout unchanged.
Database
Transfer operations update classification metadata only. The verifier checks required columns, types, nullability, validated ownership constraints and zero-row SELECT access in a read-only transaction. Migration-journal discrepancies are diagnostic warnings; it performs no repairs. Main's migrations 0016–0018 were applied only to the local test database for validation.
Security impact
New reads require workspace access; writes require editor access. Tests cover foreign-workspace records and accounts, stale/concurrent requests, transaction rollback, paired edit/delete guards, and allocated Bills evidence. Counterparts and legacy groups use bounded reads. Database and storage credentials remain server-only and untracked; production verification was read-only.
Screenshots
Synthetic fixtures, refreshed on the combined production build: