Repository navigation
fix(quick-switcher): highlight the selected Open Quickly row after a search - #3789
Merged
Merged
Conversation
datlechin
enabled auto-merge (squash)
October 22, 2026 14:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ForEachand no.idon a row. The nestedForEach(groups) { ForEach(items) }in aLazyVStackkept a row realized under a removed group (Tables, Recent) on screen once a search moved its item into the results, and never updated it: no highlight, no bold match, and a stale second highlight.QuickSwitcherListowns that rule and the scrolling for Open Quickly, Jump to Column and the recent-tab switcher.@concurrent. Under approachable concurrency they ran on the main actor: 100 to 400 ms per keystroke in the Connections scope with 5 to 10 connections of 2,000 tables.Test plan
QuickSwitcherSelectionRenderingTestsrenders the real panel and reads the drawn selection: highlight after a query, scroll back to a kept selection, header on arrow up. All three fail on main.QuickSwitcherViewModelTests: rows, arrows replayed in order with clamping, a keystroke drops a pending arrow, same-search refilter, search generation.ColumnJumpViewModelTests: search generation.OpenQuicklyCommandUITestsruns on CI only, since Automation Mode is off on this Mac.Fixes #3785