Repository navigation
fix(ssh): name servers limited to SHA-1 and other dropped SSH algorithms - #3782
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
libssh2_session_supported_algsagainst libs-2 and libs-5, macOS and the iOS simulator alike, it no longer offers:diffie-hellman-group1-sha1,diffie-hellman-group14-sha1,diffie-hellman-group-exchange-sha1ssh-rsa,ssh-rsa-cert-v01@openssh.com3des-cbc,blowfish-cbc,cast128-cbc,arcfour,arcfour128hmac-sha1,hmac-sha1-96,hmac-sha1-etm@openssh.com,hmac-md5,hmac-md5-96,hmac-ripemd160,hmac-ripemd160@openssh.comssh-dsswas already absent in libs-2 (libssh2 1.11.1), so it is not part of this change.ssh-rsasignatures got libssh2's -17 "No signing signature matched" (0.83.0-beta.1 signed in). It is nownegotiationFailedat a newkeySignaturestage: "TablePro and the SSH server have no signature algorithm in common for this key."ssh-test-servers.shaddssha1kex,rsahost,sha1macandrsasig, with matrix cells for both apps.lackingreads the app's libssh2 archive instead of the harness, since the app now names these methods.check-libssh2-algorithms.shprints what a libs release dropped.apple/RELEASING.md, iOS).SSHNegotiationFailureTestscallswithoutPseudoMethods, the new name ofclientMethods.Test plan
SSHServerProposalTests(new),SSHNegotiationFailureTests,LibSSH2NegotiationTests(scripted server offering the dropped methods to the shipped libssh2), iOSLibSSH2AuthenticationTests,SSHTunnelFactoryTests,SSHTunnelErrorClassifierTests.apple/scripts/probes/check-ssh-tunnel-matrix.shwith libs-5 against OpenSSH 10.3 and 9.9: 195 of 196 cells.ios/v10/30-clients-one-tunnelhad client 17, then 21, of 30 reset at load averages of 41 and 28: the iOS listen backlog is 16, and this change does not touch the listener or relay.apple/scripts/probes/check-libssh2-algorithms.shprints exactly the list above.Docs: TableProApp/docs#121 (draft, lands after this).