Repository navigation
feat(query): build a join query from the foreign keys between tables - #3763
Merged
Merged
Conversation
…-builder # Conflicts: # apple/TablePro/Resources/Localizable.xcstrings
datlechin
enabled auto-merge (squash)
October 21, 2026 16:11
…-builder # Conflicts: # apple/TablePro/Resources/Localizable.xcstrings # apple/TablePro/Views/Main/MainContentCoordinator.swift # apple/TablePro/Views/Main/MainContentView.swift
…-builder # Conflicts: # apple/TablePro/ViewModels/ERDiagramViewModel.swift # apple/TablePro/Views/ERDiagram/ERDiagramScene.swift # apple/TablePro/Views/ERDiagram/ERDiagramSceneView.swift # apple/TablePro/Views/ERDiagram/ERDiagramToolbar.swift # apple/TablePro/Views/ERDiagram/ERDiagramView.swift # apple/TablePro/Views/Main/Child/MainEditorContentView.swift # apple/TableProTests/Helpers/ERDiagramLoadFixture.swift # apple/TableProTests/Views/ERDiagram/ERDiagramPointerInputTests.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SELECT *.FilterSQLGenerator, so values are typed and escaped the same way.selectedNodeId:now passselectedNodeIds:.parent(id)for tableParent) resolve to the catalog name; the ER diagram dropped that edge before.Test plan
JoinGraphTests,JoinQueryDraftTests,JoinQuerySQLWriterTests: paths, relinking, SQL per dialect, LEFT and CROSS joins, columns, WHERE escaping, schema qualification.JoinBuilderOpeningTests: new tab on the builder's database, sidebar seeding keeps one schema.ERDiagramPointerInputTests: Command/Shift-click, right-click menu, disabled command, multi-selection accessibility. Its fixture offers no join builder unless a test asks, so the diagram menu tests keep their expectations.ERDiagramGraphBuilderTests,ERDiagramViewModelLoadTests,ForeignKeyTargetScopeTests: case-mismatched reference keeps its edge, key into another schema is not drawn.MainMenuBuilderTests: menu enablement.JoinBuilderUITestspicks album and artist on the fixture's diagram and reads the join onalbum.artist_id = artist.id, quoted the SQLite driver's way, in the new tab.Screenshots
No join builder existed before.
Fixes #2531