Repository navigation
feat(editor): tab stops and fields in saved query snippets - #3741
Merged
Merged
Conversation
datlechin
enabled auto-merge (squash)
October 21, 2026 05:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
${1:default},${1},${1|ASC,DESC|}and${0}. The same number twice is one field, mirrored as you type.TabandShift+Tabmove between fields with the field's text selected.Escape, or a selection outside the inserted SQL, ends the session.;;still works and means${0}. A bare$1,$$or$tag$stays literal. A field left open leaves the whole query as written.;;.Not in this PR
HanaMetadata.swift:43): a registry plugin that writes${1:SCHEMA}would insert it literally on hosts without this engine, so it needs a host version gate first.MainContentCoordinator+Favorites.swift:15appends the text to the tab).;;never worked there either.;;only (SQLCompletionInsertion.resolve).${1}${1}, or adjacent copies emptied together) collapse into one caret, so typing fills one copy.Test plan
SQLSnippetTests(TableProAutocompleteTests): fields, mirrors, choices, nesting, escapes,$1/$$/$tag$literal,;;as the final stop, the nesting and expansion limits.SnippetSessionTests,SnippetEditingTests(TableProEditorKitTests): Tab visits three fields in order then the end, Shift-Tab, typing into a mirror, adjacent copies, a nested field's edge, completion into mirrors and its undo, a filter edit, Escape, a click outside, choices, undo of the expansion, document replace.EmphasisManagerTests.anUnfilledOutlineDrawsNoCopyOfItsText.QueryCompletionAdapterLifecycleTests: accepting a saved query with fields selects the first field and keeps$1;;;alone places the caret as before.Fixes #3612