Repository navigation
fix(sidebar): open Show All Tables as a read-only grid, not an editor - #3674
Merged
Merged
Conversation
Show All Tables put the plugin's listing SQL in a query editor tab and ran nothing. It now opens a listing tab per database and schema that loads the catalog listing over a metadata connection and shows it in a read-only grid, sortable in place and refreshed with Cmd+R. The tab saves only its container; the statement is built from the plugin each time it loads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Show All Tables, on the Tables section's menu in the sidebar, opened a query editor tab holding the plugin's listing SQL and ran nothing. The reader had to press Run to see the tables. On MongoDB and Redis the command ran, but in an editor tab. The listing has opened as an unrun editor tab since the switch to native window tabs.
Change
SCAN, says it is partial instead of passing off one page as every table.Verified
CoordinatorTableListingTestsandTableListingViewModelTestscover opening, reuse, refresh, failure, superseded and cancelled loads, and partial listings. The full Unit plan passes. Checked in a Debug build against PostgreSQL: sort and Cmd+R work on the listing.Screenshots
Not in this PR
'lists no tables. DuckDB expects the escaped value, so the fix needs a plugin contract change.