Skip to content

fix(sidebar): open Show All Tables as a read-only grid, not an editor - #3674

Merged
datlechin merged 2 commits into
mainfrom
fix/show-all-tables-grid
Oct 19, 2026
Merged

datlechin merged 2 commits into
mainfrom
fix/show-all-tables-grid

Conversation

@datlechin

Copy link
Copy Markdown
Member

Why

Show All Tables, on the Tables section's menu in the sidebar, opened a query editor tab holding the plugin's listing SQL and ran nothing. The reader had to press Run to see the tables. On MongoDB and Redis the command ran, but in an editor tab. The listing has opened as an unrun editor tab since the switch to native window tabs.

Change

  • Show All Tables opens a read-only listing tab, titled after the section (for example "Tables: public"), showing each table's row estimate, sizes and comment in the data grid. There is no editor.
  • Choosing it again returns to the same tab and refreshes it. Cmd+R refreshes it, a header click sorts the rows, and the sort and column widths survive switching tabs.
  • The tab saves only its database and schema. The listing is built from the plugin each time it loads, over a metadata connection, like the sidebar's own reads.
  • A listing the driver returns in pages, such as a Redis SCAN, says it is partial instead of passing off one page as every table.

Verified

CoordinatorTableListingTests and TableListingViewModelTests cover opening, reuse, refresh, failure, superseded and cancelled loads, and partial listings. The full Unit plan passes. Checked in a Debug build against PostgreSQL: sort and Cmd+R work on the listing.

Screenshots

Dark Light
Before Before, dark Before, light
After After, dark After, light

Not in this PR

  • PostgreSQL, Redshift and Oracle escape the schema name a second time in their listing SQL, so a schema whose name contains ' lists no tables. DuckDB expects the escaped value, so the fix needs a plugin contract change.
  • Double-clicking a listed row does not open that table yet.

Show All Tables put the plugin's listing SQL in a query editor tab and ran
nothing. It now opens a listing tab per database and schema that loads the
catalog listing over a metadata connection and shows it in a read-only grid,
sortable in place and refreshed with Cmd+R. The tab saves only its container;
the statement is built from the plugin each time it loads.
@datlechin
datlechin merged commit 2953935 into main Oct 19, 2026
17 checks passed
@datlechin
datlechin deleted the fix/show-all-tables-grid branch October 19, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant