Repository navigation
ci(plugins): check the PluginKit minimum and test the ABI verdict - #3561
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to #3552.
check-pluginkit-abi.shdropped the base'sTABLEPRO_PLUGINKIT_MINIMUM_VERSION, so a PR could lower the minimum with no ABI change, or keep a reverted break's minimum above the kit, which traps thecompatibleKitsrange inPluginManager. An xcconfig it could not parse failed the step with no message.Change
--frozenincluded. The failure names both settings.Configs/PluginKit.xcconfigfails with an::error::.scripts/ci/test_check_pluginkit_abi.pycovers each verdict,--frozenand the default base against a stubxcodebuild, in Repo Hygiene.plugin-system.mdpoints toci.mdfor when CI runs the check; the fix-issueabirow takes[base].Verified
verify.sh abion Xcode 27 passes as unchanged and fails with the minimum at 18.Not in this PR