Repository navigation
test(linux): read a corpus of real values back on every engine - #3559
Merged
Merged
Conversation
# Conflicts: # linux/docs/adding-drivers.md # linux/docs/testing.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Release criterion 3 asks for a corpus test per engine with real values. Running one found values the grid showed wrong: a MySQL BIT(1) as
00000001, a DATETIME(6) or SQL Server datetime2(7) without its declared digits in a table tab, and a PostgreSQL date or timestamp past 262143 AD as unreadable.Change
value_corpus_suite!writes each engine's dates, times, decimals, JSON, UUIDs, Unicode, binary and other common values as SQL, then checks the text a table tab, its Export All and an editor run show.Verified
The corpus passes on PostgreSQL, MySQL, MariaDB, SQL Server, ClickHouse and SQLite; on MySQL and SQL Server it failed before the fixes. The driver pages list what sqlx and tiberius still hide from an editor run.