refactor: migrate commands to AppCommands typed bus#1128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 5 commands. New
AppCommandstyped publisher hub (parallel toAppEvents). 16 Tier 3 command notifications migrated.AppNotifications.swiftdeleted (became empty after migration). One declared notification (showFeedbackWindow) was already dead code; removed without a publisher.Migrated
Row commands (commit e47d12b, 5 commands, all Void):
deleteSelectedRows, addNewRow, duplicateRow, copySelectedRows, pasteRows
Refresh and file commands (commit 9a96a3e, 7 commands):
PassthroughSubject<UUID?, Never>(connection scope filter)PassthroughSubject<[URL], Never>PassthroughSubject<String, Never>(the query)PassthroughSubject<String, Never>(bundle id)Window/sheet commands (commit 0ace8bb, 4 commands):
PassthroughSubject<DatabaseTypeChooserPayload, Never>Foundation
TablePro/Core/Events/AppCommands.swift(new, commit 13267c2) — singleton with onePassthroughSubjectper command. Sits parallel toAppEvents(domain events, migrated in PR #1118 + #1119).Cleanup
TablePro/Core/Services/Infrastructure/AppNotifications.swiftdeleted (all declarations migrated).TableProApp.swiftandWindowOpenerBridge.swift.showFeedbackWindowremoved entirely — was declared but never observed; dead code per CLAUDE.md "no half-finished implementations".Verification
Notification.Name.<command>returns zero hits for the 16 migrated commands.Test plan