refactor: phase 2 tail — declare capabilities for 14 plugins#1121
Merged
refactor: phase 2 tail — declare capabilities for 14 plugins#1121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 tail. 14 plugins declare honest
PluginCapabilitiesbased on what they actually implement. Pattern proven by SQLite migration in PR #1117. NO ABI bump (additive, default impl in protocol extension).Verification
currentPluginKitVersionstays 9.Info.plistTableProPluginKitVersionchanged.PluginDatabaseDriver.Per-plugin (honest, code-verified)
SQL plugins (commit 062f32a):
NoSQL plugins (commit b6cdda3):
Cloud plugins (commit dee1bfb):
Notable judgment calls
executeParameterizedoverride, so it falls back to default substitution. Honest declaration; revisit when binding gets wired.truncateTableStatementshas stale signature(table:cascade:)that does not satisfy current protocol(table:schema:cascade:). Worth a follow-up signature fix; out of scope for additive PR.truncateTableStatementsexplicitly returns nil.fetchDatabases, notfetchSchemas.supportsSchemasis false.supportedMaintenanceOperations(VACUUM/ANALYZE/REINDEX/CLUSTER) but the foundation OptionSet has no maintenance capability. Not invented.Out of scope
PluginProcedureFunctionSupportsub-protocol (no plugin currently has procedure/function fetch).PluginAlterDDL,PluginMaintenance).Test plan