Skip to content

[TASK] Reintroduce missing features, extension cleanup#893

Open
twoldanski wants to merge 1 commit into
masterfrom
task/v5-improvements
Open

[TASK] Reintroduce missing features, extension cleanup#893
twoldanski wants to merge 1 commit into
masterfrom
task/v5-improvements

Conversation

@twoldanski

Copy link
Copy Markdown
Collaborator
  • workspace support (via event)
  • php templates (via new API from Core)
  • extension API cleanup (interface, more consistent across the board)
  • optimizations, code hardening (more checks)
  • removed redundant xclasses for better implementations
  • handle more deprecations for v14

Resolves: #887
Resolves: #865
Resolves: #889
Resolves: #830
Resolves: #891

- workspace support (via event)
- php templates (via new API from Core)
- extension API cleanup (interface, more consistent across the board)
- optimizations, code hardening (more checks)
- removed redundant xclasses for better implementations
- handle more deprecations for v14

Resolves: #887
Resolves: #865
Resolves: #889
Resolves: #830
Resolves: #891
@twoldanski twoldanski requested a review from lukaszuznanski May 26, 2026 07:58
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 26439917307

Coverage decreased (-5.0%) to 70.455%

Details

  • Coverage decreased (-5.0%) from the base build.
  • Patch coverage: 163 uncovered changes across 15 files (360 of 523 lines covered, 68.83%).
  • 167 coverage regressions across 7 files.

Uncovered Changes

Top 10 Files by Coverage Impact Changed Covered %
Classes/Form/Service/FormTranslationService.php 61 0 0.0%
Classes/Form/Finisher/JsonRedirectFinisher.php 21 0 0.0%
Classes/Event/Listener/AfterPageUriGeneratedListener.php 23 5 21.74%
Classes/Event/Listener/HeadlessHreflangGeneratorListener.php 13 0 0.0%
Classes/ViewHelpers/LoginFormViewHelper.php 12 0 0.0%
Classes/DataProcessing/RootSiteProcessing/SiteProvider.php 8 0 0.0%
Classes/Utility/UrlUtility.php 72 65 90.28%
Classes/View/HeadlessPhpView.php 62 55 88.71%
Classes/Event/Listener/AfterLinkIsGeneratedListener.php 8 4 50.0%
Classes/Middleware/CookieDomainPerSite.php 21 18 85.71%
Total (32 files) 523 360 68.83%

Coverage Regressions

167 previously-covered lines in 7 files lost coverage.

File Lines Losing Coverage Coverage
Classes/ViewHelpers/LoginFormViewHelper.php 116 0.0%
Classes/XClass/Controller/LoginController.php 32 34.69%
Classes/Event/Listener/AfterLinkIsGeneratedListener.php 10 65.38%
Classes/Form/Finisher/JsonRedirectFinisher.php 3 0.0%
Classes/Utility/UrlUtility.php 3 88.59%
Classes/Form/Service/FormTranslationService.php 2 0.0%
Classes/Utility/FileUtility.php 1 97.16%

Coverage Stats

Coverage Status
Relevant Lines: 1936
Covered Lines: 1364
Line Coverage: 70.45%
Coverage Strength: 7.36 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants